[PATCH mptcp-next] selftests: mptcp: move prefix tests of addr_nr_ns2 together

[PATCH mptcp-next] selftests: mptcp: move prefix tests of addr_nr_ns2 together

[Geliang Tang]

Move the fullmesh prefix test of addr_nr_ns2 together with its other
prefix tests.

Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index ff83ef426df5..2957fe414639 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -706,6 +706,7 @@ do_transfer()
 		addr_nr_ns1=${addr_nr_ns1:10}
 	fi
 
+	local flags="subflow"
 	if [[ "${addr_nr_ns2}" = "fastclose_"* ]]; then
 		# disconnect
 		extra_args="$extra_args -I ${addr_nr_ns2:10}"
@@ -713,6 +714,9 @@ do_transfer()
 	elif [[ "${addr_nr_ns2}" = "userspace_"* ]]; then
 		userspace_pm=1
 		addr_nr_ns2=${addr_nr_ns2:10}
+	elif [[ "${addr_nr_ns2}" = "fullmesh_"* ]]; then
+		flags="${flags},fullmesh"
+		addr_nr_ns2=${addr_nr_ns2:9}
 	fi
 
 	if [ $userspace_pm -eq 1 ]; then
@@ -832,12 +836,6 @@ do_transfer()
 		fi
 	fi
 
-	local flags="subflow"
-	if [[ "${addr_nr_ns2}" = "fullmesh_"* ]]; then
-		flags="${flags},fullmesh"
-		addr_nr_ns2=${addr_nr_ns2:9}
-	fi
-
 	# if newly added endpoints must be deleted, give the background msk
 	# some time to created them
 	[ $addr_nr_ns1 -gt 0 ] && [ $addr_nr_ns2 -lt 0 ] && sleep 1
-- 
2.35.3

Re: selftests: mptcp: move prefix tests of addr_nr_ns2 together: Tests Results

[MPTCP CI]

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal:
  - Unstable: 3 failed test(s): packetdrill_add_addr selftest_mptcp_join selftest_simult_flows 🔴:
  - Task: https://cirrus-ci.com/task/5800980959723520
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5800980959723520/summary/summary.txt

- KVM Validation: debug:
  - Unstable: 2 failed test(s): packetdrill_add_addr selftest_mptcp_join 🔴:
  - Task: https://cirrus-ci.com/task/5238031006302208
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5238031006302208/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/35a5cdc0a810


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)

Re: [PATCH mptcp-next] selftests: mptcp: move prefix tests of addr_nr_ns2 together

[Mat Martineau]

On Mon, 8 Aug 2022, Geliang Tang wrote:

> Move the fullmesh prefix test of addr_nr_ns2 together with its other
> prefix tests.
>
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>

Looks good to me, thanks Geliang:

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

> ---
> tools/testing/selftests/net/mptcp/mptcp_join.sh | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> index ff83ef426df5..2957fe414639 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> @@ -706,6 +706,7 @@ do_transfer()
> 		addr_nr_ns1=${addr_nr_ns1:10}
> 	fi
>
> +	local flags="subflow"
> 	if [[ "${addr_nr_ns2}" = "fastclose_"* ]]; then
> 		# disconnect
> 		extra_args="$extra_args -I ${addr_nr_ns2:10}"
> @@ -713,6 +714,9 @@ do_transfer()
> 	elif [[ "${addr_nr_ns2}" = "userspace_"* ]]; then
> 		userspace_pm=1
> 		addr_nr_ns2=${addr_nr_ns2:10}
> +	elif [[ "${addr_nr_ns2}" = "fullmesh_"* ]]; then
> +		flags="${flags},fullmesh"
> +		addr_nr_ns2=${addr_nr_ns2:9}
> 	fi
>
> 	if [ $userspace_pm -eq 1 ]; then
> @@ -832,12 +836,6 @@ do_transfer()
> 		fi
> 	fi
>
> -	local flags="subflow"
> -	if [[ "${addr_nr_ns2}" = "fullmesh_"* ]]; then
> -		flags="${flags},fullmesh"
> -		addr_nr_ns2=${addr_nr_ns2:9}
> -	fi
> -
> 	# if newly added endpoints must be deleted, give the background msk
> 	# some time to created them
> 	[ $addr_nr_ns1 -gt 0 ] && [ $addr_nr_ns2 -lt 0 ] && sleep 1
> -- 
> 2.35.3
>
>
>

--
Mat Martineau
Intel

Re: [PATCH mptcp-next] selftests: mptcp: move prefix tests of addr_nr_ns2 together

[Matthieu Baerts]

Hi Geliang, Mat,

On 08/08/2022 03:44, Geliang Tang wrote:
> Move the fullmesh prefix test of addr_nr_ns2 together with its other
> prefix tests.

I'm glad to see you back!

Now in our tree (feat. for net-next) with Mat's RvB tag:

New patches for t/upstream:
- 1f2452544e4e: selftests: mptcp: move prefix tests of addr_nr_ns2 together
- Results: 8b0cb8f8874a..cb5660da7192 (export)


Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220809T163858

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net