From: Paolo Abeni <pabeni@redhat.com>
To: Matthieu Baerts <matttbe@kernel.org>,
Kalpan Jani <kalpan.jani@mpiricsoftware.com>,
mptcp <mptcp@lists.linux.dev>
Cc: "shardul.b" <shardul.b@mpiricsoftware.com>,
janak <janak@mpiric.us>, kalpanjani009 <kalpanjani009@gmail.com>
Subject: Re: [PATCH net v3] mptcp: fix stale skb->sk reference on subflow close
Date: Fri, 29 May 2026 12:38:14 +0200 [thread overview]
Message-ID: <b95faee7-e32b-40ac-8010-eb57948a3fbb@redhat.com> (raw)
In-Reply-To: <c3ae1aed-0ff6-4255-91c4-b0e18ea7dae7@kernel.org>
On 5/27/26 1:31 PM, Matthieu Baerts wrote:
> Hi Paolo,
>
> Thank you for your review!
>
> On 27/05/2026 19:40, Paolo Abeni wrote:
>> On 5/27/26 7:49 AM, Kalpan Jani wrote:
>>> Gentle ping on this patch sent on 19 May 2026 — I haven't seen any review feedback yet. If anyone has had a chance to look, I'd appreciate comments; otherwise I'm happy to rebase or resend if it slipped through.
>>
>> Note that maintainers are under an ever increasing influx of AI
>> generated contents that make processing incoming patches more
>> challenging every day.
>
> +1
>
>> FTR this revision LGTM.
>
> Just to be sure, does it mean that Sashiko was wrong?
>
> https://sashiko.dev/#/patchset/20260519092243.1242351-1-kalpan.jani%40mpiricsoftware.com
AFAICS, yes: the msk socket is set to TCP_CLOSE status before calling
mptcp_backlog_purge(): __mptcp_add_backlog() can't add anything to the
backlog.
> If yes, can I convert this "LGTM" as an Acked-by? :)
There is already my Suggested-by: tag, I think the latter would be
redundant?!?
/P
next prev parent reply other threads:[~2026-05-29 10:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 9:22 [PATCH net v3] mptcp: fix stale skb->sk reference on subflow close Kalpan Jani
2026-05-19 10:34 ` MPTCP CI
2026-05-27 5:49 ` Kalpan Jani
2026-05-27 9:40 ` [PATCH " Paolo Abeni
2026-05-27 11:31 ` Matthieu Baerts
2026-05-29 10:38 ` Paolo Abeni [this message]
2026-05-31 6:14 ` Matthieu Baerts
2026-05-31 6:11 ` Matthieu Baerts
2026-06-10 10:45 ` Kalpan Jani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b95faee7-e32b-40ac-8010-eb57948a3fbb@redhat.com \
--to=pabeni@redhat.com \
--cc=janak@mpiric.us \
--cc=kalpan.jani@mpiricsoftware.com \
--cc=kalpanjani009@gmail.com \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=shardul.b@mpiricsoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox