Re: [PATCH mptcp-next v4 0/7] BPF path manager, part 2

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 10/01/2025 13:40, Geliang Tang wrote:
> Hi Matt,
> 
> Thanks for your review.
> 
> On Fri, 2025-01-10 at 12:53 +0100, Matthieu Baerts wrote:
>> Hi Geliang,
>>
>> On 10/01/2025 08:36, Geliang Tang wrote:
>>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>>
>>> v4:
>>>  - move "mptcp: userspace pm set_flags id support" out of this set.
>>>  - only add 'local' parameter for set_flags, no 'remote'.
>>
>> Thank you for the new version! It now looks good to me:
>>
>> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>>
>>> Based-on: <cover.1736493803.git.tanggeliang@kylinos.cn>
>>
>> I have just one question on patch 7/7, linked to the one I had on the
>> "use GENL_REQ_ATTR_CHECK in userspace pm" series. If you are OK with
>> that, I can do the modifications while applying these two series.
> 
> Sure. Please update these patches for me when applying them.

Done! Now in our tree (feat. for net-next):

New patches for t/upstream:
- d3401e36d040: mptcp: make three pm wrappers static
- ebf01bfde1e1: mptcp: drop skb parameter of get_addr
- 7852370411cf: mptcp: add id parameter for get_addr
- 8f55135854d2: mptcp: reuse sending nlmsg code in get_addr
- 8e9d415a217a: mptcp: drop skb parameter of set_flags
- 6a7efe19ce07: mptcp: change rem type of set_flags
- 7551b7b78dd7: mptcp: add local parameter for set_flags
- Results: 472c88326ee3..99ab203e6854 (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/9b5e8499e5017c4a434df8ce0f8f983e3eb5a820/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.