MPTCP Linux Development
 help / color / mirror / Atom feed
From: Geliang Tang <geliang@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v4 0/7] BPF path manager, part 2
Date: Fri, 10 Jan 2025 20:40:53 +0800	[thread overview]
Message-ID: <e2a3161d3db3bd0d8266056876382a6293da6509.camel@kernel.org> (raw)
In-Reply-To: <523f8cec-640b-4ada-87b3-21c86a4b5822@kernel.org>

Hi Matt,

Thanks for your review.

On Fri, 2025-01-10 at 12:53 +0100, Matthieu Baerts wrote:
> Hi Geliang,
> 
> On 10/01/2025 08:36, Geliang Tang wrote:
> > From: Geliang Tang <tanggeliang@kylinos.cn>
> > 
> > v4:
> >  - move "mptcp: userspace pm set_flags id support" out of this set.
> >  - only add 'local' parameter for set_flags, no 'remote'.
> 
> Thank you for the new version! It now looks good to me:
> 
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> > Based-on: <cover.1736493803.git.tanggeliang@kylinos.cn>
> 
> I have just one question on patch 7/7, linked to the one I had on the
> "use GENL_REQ_ATTR_CHECK in userspace pm" series. If you are OK with
> that, I can do the modifications while applying these two series.

Sure. Please update these patches for me when applying them.

Thanks,
-Geliang

> 
> Cheers,
> Matt


  reply	other threads:[~2025-01-10 12:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10  7:36 [PATCH mptcp-next v4 0/7] BPF path manager, part 2 Geliang Tang
2025-01-10  7:36 ` [PATCH mptcp-next v4 1/7] mptcp: make three pm wrappers static Geliang Tang
2025-01-10  7:36 ` [PATCH mptcp-next v4 2/7] mptcp: drop skb parameter of get_addr Geliang Tang
2025-01-10  7:36 ` [PATCH mptcp-next v4 3/7] mptcp: add id parameter for get_addr Geliang Tang
2025-01-10  7:36 ` [PATCH mptcp-next v4 4/7] mptcp: reuse sending nlmsg code in get_addr Geliang Tang
2025-01-10  7:36 ` [PATCH mptcp-next v4 5/7] mptcp: drop skb parameter of set_flags Geliang Tang
2025-01-10  7:36 ` [PATCH mptcp-next v4 6/7] mptcp: change rem type " Geliang Tang
2025-01-10  7:36 ` [PATCH mptcp-next v4 7/7] mptcp: add local parameter for set_flags Geliang Tang
2025-01-10 11:53   ` Matthieu Baerts
2025-01-10  9:12 ` [PATCH mptcp-next v4 0/7] BPF path manager, part 2 MPTCP CI
2025-01-10 11:53 ` Matthieu Baerts
2025-01-10 12:40   ` Geliang Tang [this message]
2025-01-12 13:09     ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2a3161d3db3bd0d8266056876382a6293da6509.camel@kernel.org \
    --to=geliang@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=tanggeliang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox