MPTCP Linux Development
 help / color / mirror / Atom feed
* [PATCH mptcp-next v9 00/23] BPF packet scheduler updates
@ 2023-06-14  2:20 Geliang Tang
  2023-06-14  2:20 ` [PATCH mptcp-next v9 01/23] Squash to "mptcp: drop last_snd and MPTCP_RESET_SCHEDULER" Geliang Tang
                   ` (22 more replies)
  0 siblings, 23 replies; 28+ messages in thread
From: Geliang Tang @ 2023-06-14  2:20 UTC (permalink / raw)
  To: mptcp; +Cc: Geliang Tang

v9:
 - merge 'Squash to "BPF packet scheduler updates v8"' and 'mptcp:
 make the contexts array of sched_data invisible in BPF'

v8:
 address Paolo's comments in v7:
 - add sched_data into mptcp_sock as new field, not an pointer.
 - drop rename __mptcp_set_timeout, export mptcp_set_timeout into BPF
   context instead.
 - add a comment in bpf_burst to explan why not use
   "ssk = send_info[SSK_MODE_ACTIVE].ssk;" directly.
 - move mptcp_subflow_tcp_sock into bpf_tcp_helpers.h.

v7:
 - drop more last_snd, only set it in bpf_rr.
 - 1-10: save sched_data at mptcp_sock, for issues #342
 - 11-16: add bpf_burst scheduler
 - 17-19: add bpf_stale scheduler, for issues #349

v6:
 - Only update patches 14, 15. Add a helper bpf_mptcp_subflow_ctx, fix
   bug in bpf_burst_get_retrans().

v5:
 - 1-9: save sched_data at mptcp_sock, for issues #342
 - 10-15: add bpf_burst scheduler
 - 16-18: add bpf_stale scheduler, for issues #349

v4:
 - drop "mptcp: add three helpers for bpf_burst", implement the helpers
   in the bpf context directly.

v3:
 - address Florian's comments in v2.
 - split into three more patches.

v2:
 - fix this error reported by CI:
KASAN: slab-use-after-free in __mptcp_close_ssk (net/mptcp/protocol.c:2461)
 - add bpf burst scheduler.

This patchset adds sched_data pointer into mptcp_sock to to save some
data at MPTCP and subflows levels.

With these changes, the old patch "mptcp: register default scheduler" in
[1] now works.

https://patchwork.kernel.org/project/mptcp/cover/cover.1665753926.git.geliang.tang@suse.com/ [1]
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/342
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/349

Geliang Tang (23):
  Squash to "mptcp: drop last_snd and MPTCP_RESET_SCHEDULER"
  Squash to "mptcp: add struct mptcp_sched_ops"
  Squash to "mptcp: add sched_data_set_contexts helper"
  mptcp: add mptcp_subflow_ctx_by_pos helper
  Squash to "mptcp: add scheduler wrappers"
  mptcp: add last_snd in sched_data
  mptcp: add snd_burst in sched_data
  mptcp: register default scheduler
  Squash to "bpf: Add bpf_mptcp_sched_ops"
  Squash to "bpf: Add bpf_mptcp_sched_kfunc_set"
  Squash to "selftests/bpf: Add mptcp sched structs"
  Squash to "selftests/bpf: Add bpf_first scheduler"
  Squash to "selftests/bpf: Add bpf_bkup scheduler"
  Squash to "selftests/bpf: Add bpf_rr scheduler"
  Squash to "selftests/bpf: Add bpf_red scheduler"
  mptcp: add two wrappers needed by bpf_burst
  bpf: Add bpf_burst write accesses
  bpf: Export more bpf_burst related functions
  selftests/bpf: Add bpf_burst scheduler
  selftests/bpf: Add bpf_burst test
  bpf: Add subflow bit flags write accesses
  selftests/bpf: Add bpf_stale scheduler
  selftests/bpf: Add bpf_stale test

 include/net/mptcp.h                           |   5 +-
 net/mptcp/bpf.c                               |  56 +++++-
 net/mptcp/protocol.c                          |  27 +--
 net/mptcp/protocol.h                          |  15 +-
 net/mptcp/sched.c                             |  65 +++++-
 tools/testing/selftests/bpf/bpf_tcp_helpers.h |  22 +-
 .../testing/selftests/bpf/prog_tests/mptcp.c  |  76 +++++++
 .../selftests/bpf/progs/mptcp_bpf_bkup.c      |  11 +-
 .../selftests/bpf/progs/mptcp_bpf_burst.c     | 189 ++++++++++++++++++
 .../selftests/bpf/progs/mptcp_bpf_first.c     |   2 +-
 .../selftests/bpf/progs/mptcp_bpf_red.c       |   6 +-
 .../selftests/bpf/progs/mptcp_bpf_rr.c        |  14 +-
 .../selftests/bpf/progs/mptcp_bpf_stale.c     |  65 ++++++
 13 files changed, 494 insertions(+), 59 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_burst.c
 create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_stale.c

-- 
2.35.3


^ permalink raw reply	[flat|nested] 28+ messages in thread
end of thread, other threads:[~2023-06-17  0:54 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-14  2:20 [PATCH mptcp-next v9 00/23] BPF packet scheduler updates Geliang Tang
2023-06-14  2:20 ` [PATCH mptcp-next v9 01/23] Squash to "mptcp: drop last_snd and MPTCP_RESET_SCHEDULER" Geliang Tang
2023-06-14  2:20 ` [PATCH mptcp-next v9 02/23] Squash to "mptcp: add struct mptcp_sched_ops" Geliang Tang
2023-06-14  2:20 ` [PATCH mptcp-next v9 03/23] Squash to "mptcp: add sched_data_set_contexts helper" Geliang Tang
2023-06-14  2:20 ` [PATCH mptcp-next v9 04/23] mptcp: add mptcp_subflow_ctx_by_pos helper Geliang Tang
2023-06-14  2:20 ` [PATCH mptcp-next v9 05/23] Squash to "mptcp: add scheduler wrappers" Geliang Tang
2023-06-17  0:54   ` Mat Martineau
2023-06-14  2:20 ` [PATCH mptcp-next v9 06/23] mptcp: add last_snd in sched_data Geliang Tang
2023-06-14  2:20 ` [PATCH mptcp-next v9 07/23] mptcp: add snd_burst " Geliang Tang
2023-06-14  2:20 ` [PATCH mptcp-next v9 08/23] mptcp: register default scheduler Geliang Tang
2023-06-14  2:20 ` [PATCH mptcp-next v9 09/23] Squash to "bpf: Add bpf_mptcp_sched_ops" Geliang Tang
2023-06-14  2:20 ` [PATCH mptcp-next v9 10/23] Squash to "bpf: Add bpf_mptcp_sched_kfunc_set" Geliang Tang
2023-06-14  2:20 ` [PATCH mptcp-next v9 11/23] Squash to "selftests/bpf: Add mptcp sched structs" Geliang Tang
2023-06-14  2:20 ` [PATCH mptcp-next v9 12/23] Squash to "selftests/bpf: Add bpf_first scheduler" Geliang Tang
2023-06-14  2:21 ` [PATCH mptcp-next v9 13/23] Squash to "selftests/bpf: Add bpf_bkup scheduler" Geliang Tang
2023-06-14  2:21 ` [PATCH mptcp-next v9 14/23] Squash to "selftests/bpf: Add bpf_rr scheduler" Geliang Tang
2023-06-14  2:21 ` [PATCH mptcp-next v9 15/23] Squash to "selftests/bpf: Add bpf_red scheduler" Geliang Tang
2023-06-14  2:21 ` [PATCH mptcp-next v9 16/23] mptcp: add two wrappers needed by bpf_burst Geliang Tang
2023-06-14  2:21 ` [PATCH mptcp-next v9 17/23] bpf: Add bpf_burst write accesses Geliang Tang
2023-06-14  2:21 ` [PATCH mptcp-next v9 18/23] bpf: Export more bpf_burst related functions Geliang Tang
2023-06-14  2:21 ` [PATCH mptcp-next v9 19/23] selftests/bpf: Add bpf_burst scheduler Geliang Tang
2023-06-14  2:21 ` [PATCH mptcp-next v9 20/23] selftests/bpf: Add bpf_burst test Geliang Tang
2023-06-14  2:21 ` [PATCH mptcp-next v9 21/23] bpf: Add subflow bit flags write accesses Geliang Tang
2023-06-14  2:21 ` [PATCH mptcp-next v9 22/23] selftests/bpf: Add bpf_stale scheduler Geliang Tang
2023-06-14  2:21 ` [PATCH mptcp-next v9 23/23] selftests/bpf: Add bpf_stale test Geliang Tang
2023-06-14  3:01   ` selftests/bpf: Add bpf_stale test: Build Failure MPTCP CI
2023-06-14  4:41   ` selftests/bpf: Add bpf_stale test: Tests Results MPTCP CI
2023-06-14  6:22   ` MPTCP CI

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox