[PATCH mptcp-next] Squash to "selftests: mptcp: add subflow limits test-cases"

[PATCH mptcp-next] Squash to "selftests: mptcp: add subflow limits test-cases"

[Matthieu Baerts]

From: Paolo Abeni <pabeni@redhat.com>

The test -- "delete and re-add" introduced by the above commit -- is
failing on the different CIs with a debug kernel config. It is also
failing without the debug config but it is less frequent, only on the
public CI.

Increasing the packet size from 1KB to 4KB makes the kernel sending
multiple packets and it seems to fix the issues reported by the
different CIs.

Note: Paolo shared the diff on IRC without a commit message. I prefer to
apply it like that (without his SoB) so we can stop ignoring CI's
output.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/274
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---

Notes:
    to be squashed in "selftests: mptcp: add subflow limits test-cases"

 tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index 5763595c885b..48ef112f42c2 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -2610,7 +2610,7 @@ endpoint_tests()
 		pm_nl_set_limits $ns1 1 1
 		pm_nl_set_limits $ns2 1 1
 		pm_nl_add_endpoint $ns2 10.0.2.2 id 2 dev ns2eth2 flags subflow
-		run_tests $ns1 $ns2 10.0.1.1 0 0 0 slow &
+		run_tests $ns1 $ns2 10.0.1.1 4 0 0 slow &
 
 		wait_mpj $ns2
 		pm_nl_del_endpoint $ns2 2 10.0.2.2
-- 
2.34.1

Re: [PATCH mptcp-next] Squash to "selftests: mptcp: add subflow limits test-cases"

[Matthieu Baerts]

Hello,

On 06/05/2022 19:18, Matthieu Baerts wrote:
> From: Paolo Abeni <pabeni@redhat.com>
> 
> The test -- "delete and re-add" introduced by the above commit -- is
> failing on the different CIs with a debug kernel config. It is also
> failing without the debug config but it is less frequent, only on the
> public CI.
> 
> Increasing the packet size from 1KB to 4KB makes the kernel sending
> multiple packets and it seems to fix the issues reported by the
> different CIs.
> 
> Note: Paolo shared the diff on IRC without a commit message. I prefer to
> apply it like that (without his SoB) so we can stop ignoring CI's
> output.
> 
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/274

Just applied in our tree:

- b195639989ab: "squashed" in "selftests: mptcp: add subflow limits
test-cases"
- Results: ffee67422349..825394fc0bc5 (export)
- Results: a2c76d73f38a..ca8b19c6d86b (export-net)


Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220506T172517
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20220506T172517
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export-net

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

Re: Squash to "selftests: mptcp: add subflow limits test-cases": Tests Results

[MPTCP CI]

Hi Paolo,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal:
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/4956666226540544
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/4956666226540544/summary/summary.txt

- KVM Validation: debug:
  - Unstable: 3 failed test(s): packetdrill_add_addr selftest_diag selftest_mptcp_join 🔴:
  - Task: https://cirrus-ci.com/task/6082566133383168
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6082566133383168/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/0f00674526dd


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)