From: Jingoo Han <jg1.han@samsung.com>
To: "'David S. Miller'" <davem@davemloft.net>
Cc: netdev@vger.kernel.org,
'Shreyas Bhatewara' <sbhatewara@vmware.com>,
pv-drivers@vmware.com, 'Jingoo Han' <jg1.han@samsung.com>,
'Andy King' <acking@vmware.com>,
'Aditya Sarwade' <asarwade@vmware.com>,
'George Zhang' <georgezhang@vmware.com>
Subject: [PATCH] net: vmxnet3: remove unnecessary pci_set_drvdata()
Date: Mon, 25 Nov 2013 11:05:23 +0900 [thread overview]
Message-ID: <001701cee982$cd4cdd30$67e69790$%han@samsung.com> (raw)
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 7e2788c..a300a18 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -3132,7 +3132,6 @@ err_alloc_queue_desc:
err_alloc_shared:
dma_unmap_single(&adapter->pdev->dev, adapter->adapter_pa,
sizeof(struct vmxnet3_adapter), PCI_DMA_TODEVICE);
- pci_set_drvdata(pdev, NULL);
free_netdev(netdev);
return err;
}
--
1.7.10.4
next reply other threads:[~2013-11-25 2:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 2:05 Jingoo Han [this message]
2013-11-27 18:27 ` [Pv-drivers] [PATCH] net: vmxnet3: remove unnecessary pci_set_drvdata() Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001701cee982$cd4cdd30$67e69790$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=acking@vmware.com \
--cc=asarwade@vmware.com \
--cc=davem@davemloft.net \
--cc=georgezhang@vmware.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=sbhatewara@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox