Re: [Pv-drivers] [PATCH] net: vmxnet3: remove unnecessary pci_set_drvdata()

[Dmitry Torokhov <dtor@vmware.com>]

On Monday, November 25, 2013 11:05:23 AM Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Dmitry Torokhov <dtor@vmware.com>

> ---
>  drivers/net/vmxnet3/vmxnet3_drv.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c index 7e2788c..a300a18 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -3132,7 +3132,6 @@ err_alloc_queue_desc:
>  err_alloc_shared:
>  	dma_unmap_single(&adapter->pdev->dev, adapter->adapter_pa,
>  			 sizeof(struct vmxnet3_adapter), PCI_DMA_TODEVICE);
> -	pci_set_drvdata(pdev, NULL);
>  	free_netdev(netdev);
>  	return err;
>  }