* [PATCH] net: vmxnet3: remove unnecessary pci_set_drvdata()
@ 2013-11-25 2:05 Jingoo Han
2013-11-27 18:27 ` [Pv-drivers] " Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-11-25 2:05 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Shreyas Bhatewara', pv-drivers,
'Jingoo Han', 'Andy King',
'Aditya Sarwade', 'George Zhang'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 7e2788c..a300a18 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -3132,7 +3132,6 @@ err_alloc_queue_desc:
err_alloc_shared:
dma_unmap_single(&adapter->pdev->dev, adapter->adapter_pa,
sizeof(struct vmxnet3_adapter), PCI_DMA_TODEVICE);
- pci_set_drvdata(pdev, NULL);
free_netdev(netdev);
return err;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Pv-drivers] [PATCH] net: vmxnet3: remove unnecessary pci_set_drvdata()
2013-11-25 2:05 [PATCH] net: vmxnet3: remove unnecessary pci_set_drvdata() Jingoo Han
@ 2013-11-27 18:27 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2013-11-27 18:27 UTC (permalink / raw)
To: pv-drivers
Cc: Jingoo Han, 'David S. Miller', 'Aditya Sarwade',
netdev
On Monday, November 25, 2013 11:05:23 AM Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Dmitry Torokhov <dtor@vmware.com>
> ---
> drivers/net/vmxnet3/vmxnet3_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c index 7e2788c..a300a18 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -3132,7 +3132,6 @@ err_alloc_queue_desc:
> err_alloc_shared:
> dma_unmap_single(&adapter->pdev->dev, adapter->adapter_pa,
> sizeof(struct vmxnet3_adapter), PCI_DMA_TODEVICE);
> - pci_set_drvdata(pdev, NULL);
> free_netdev(netdev);
> return err;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-27 18:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-25 2:05 [PATCH] net: vmxnet3: remove unnecessary pci_set_drvdata() Jingoo Han
2013-11-27 18:27 ` [Pv-drivers] " Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox