From: David Laight <David.Laight@ACULAB.COM>
To: 'Stephen Hemminger' <stephen@networkplumber.org>,
David Ahern <dsahern@gmail.com>
Cc: Phil Sutter <phil@nwl.cc>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Till Maas <opensource@till.name>
Subject: RE: [iproute PATCH 4/4] lib: Enable colored output only for TTYs
Date: Wed, 15 Aug 2018 15:34:31 +0000 [thread overview]
Message-ID: <007d7ef0e49243ec82fafe3efa1d9ba3@AcuMS.aculab.com> (raw)
In-Reply-To: <20180815080406.7110bd76@xeon-e3>
From: Stephen Hemminger
> Sent: 15 August 2018 16:04
...
> > This also disables color sequence when the output is piped to a pager
> > such as less which with the -R argument can handle it just fine.
> >
> > ie., the user needs to remove the color arg when that output is not wanted.
>
> If you are going to change the color enabling, why not make it compatible
> with what ls does?
Indeed - otherwise it is very hard to debug the colour escape sequences.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2018-08-15 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 9:06 [iproute PATCH 0/4] A bunch of fixes regarding colored output Phil Sutter
2018-08-15 9:06 ` [iproute PATCH 1/4] tc: Fix typo in check for " Phil Sutter
2018-08-15 9:06 ` [iproute PATCH 2/4] bridge: Fix " Phil Sutter
2018-08-15 9:06 ` [iproute PATCH 3/4] Merge common code for conditionally " Phil Sutter
2018-08-15 9:06 ` [iproute PATCH 4/4] lib: Enable colored output only for TTYs Phil Sutter
2018-08-15 14:40 ` David Ahern
2018-08-15 15:04 ` Stephen Hemminger
2018-08-15 15:34 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=007d7ef0e49243ec82fafe3efa1d9ba3@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opensource@till.name \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox