AW: [PATCH net-next 1/8] net: mdio: realtek-rtl9300: Convert to fwnode API

["Markus Stockhausen" <markus.stockhausen@gmx.de>]

> Von: Jakub Kicinski <kuba@kernel.org> 
> Gesendet: Dienstag, 2. Juni 2026 20:06
> An: Markus Stockhausen <markus.stockhausen@gmx.de>
> Betreff: Re: [PATCH net-next 1/8] net: mdio: realtek-rtl9300: Convert to
fwnode API
> 
> On Tue,  2 Jun 2026 07:26:33 +0200 Markus Stockhausen wrote:
> > -		struct device_node *phy_dn __free(device_node) =
> > -			of_parse_phandle(to_of_node(port), "phy-handle", 0);
> > +		struct fwnode_handle *phy_fwnode __free(fwnode_handle) =
> > +			fwnode_find_reference(port, "phy-handle", 0);
> >  		/* skip ports without phys */
> > -		if (!phy_dn)
> > +		if (IS_ERR(phy_fwnode))
> >  			continue;
> >  
> > -		mdio_dn = phy_dn->parent;
> > +		struct fwnode_handle *bus_fwnode __free(fwnode_handle) =
> > +			fwnode_get_parent(phy_fwnode);
> > +		if (!bus_fwnode)
> > +			continue;
>
> Variable declarations mid functions are a no-go for netdev.
>
> If you could please move away from using the __free() crap I'd
> appreciate. Clearly missed it yesterday when applying these patches

Thanks for the reminder.

Yesterdays patches should contain neither of those. For the
new series I stupidly assumed that the existing __free usage
is accepted. Will take care about this for v2 and future patches.

Markus