* typo in ping.c?
@ 2011-01-06 3:36 Julian C. Dunn
0 siblings, 0 replies; only message in thread
From: Julian C. Dunn @ 2011-01-06 3:36 UTC (permalink / raw)
To: netdev
I sent this about a month ago to Yoshifuji Hideaki but didn't hear anything.
Perhaps it could use a wider distribution.
- Julian
-----Original Message-----
From: Julian C. Dunn [mailto:jdunn@aquezada.com]
Sent: Sunday, December 12, 2010 8:49 PM
To: 'YOSHIFUJI Hideaki'
Subject: typo in ping.c?
Hi,
I'm not an expert in C code or in iputils but I think I found a
typographical error in this commit:
http://www.linux-ipv6.org/gitweb/gitweb.cgi?p=gitroot/iputils.git;a=commitdi
ff;h=d5e3dcb81ff3828fa40eb4e8c562ca7015d7ac6a
The previous version printed the icmp_seq inline within ping_common.c, but
in your diff you are now invoking a function void pr_echo_reply().
Unfortunately, it looks like "icmp_seq" is spelled wrong: you have it
spelled as "icmp_req".
I discovered this when trying to use a tool that depended on the spelling of
"icmp_seq" and it failed.
- Julian
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-01-06 3:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-06 3:36 typo in ping.c? Julian C. Dunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox