public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michal Ruzicka" <michal.ruzicka@comstar.cz>
To: <netdev@vger.kernel.org>
Subject: multicast group memberships purge on interface delete
Date: Wed, 23 Aug 2006 13:08:11 +0200	[thread overview]
Message-ID: <021e01c6c6a4$6e7845f0$2303a8c0@mruzicka> (raw)
In-Reply-To: 019901c6bc75$872ee1f0$2303a8c0@mruzicka

Hello there,
I've got the following question/suggestion:

The situation today:
When an interface is deleted and there happen to have been some multicast 
groups joined on it only
the interface's list of multicast meberships is deleted. The sockets through 
which the groups
were joined and more importantly their associated multicast membership lists 
are left untouched.
This makes it difficult for the function that handles leaving multicast 
groups on a socket to decide
what to do with groups that were joined on such an interface (that no longer 
exists). The present
implementation is a kind of  a "best guess" (and nothnig better can probably 
be done about that).
It may even fail to leave an affected group (group that was joined on a 
deleted interface) completely
and thus block a slot in the sockets's multicast mebership list which size 
is purposely limited.

My question/suggestion:
Would it feasible to drop the relevant entries from sockets' multicast 
membership lists on the interface
delete? Yes, I do realize it would require to walk through a number of 
sockets to see if there is any
multicast entry for the interface in question to delete. But this could be 
optimized by maintaining a list
of sockets that have a multicast group joined on the interface (and keep a 
pointer to this list in the
device structure). This would ease the job of the function handling leaving 
multicast groups, made
its beahaviour more "deterministic" and possible errors reported by it more 
meaningful/reliable.

Notes:
- The suggested approach is reportedly taken by other OSes (notably NetBSD). 
The fact
that linux doesn't behave the same poses a problem for cross platform 
software for the behaviour
of different systems is different in one more detail.
- The suggested "list of sockets that have a multicast group joined on the 
interface" could also
probably be of some help when maintaining the per interface multicast source 
filter list or
per-interface multicast reception state as per RFC 3376 (IGMPv3) section 
3.2.

Thanks
Michal Ruzicka 


  parent reply	other threads:[~2006-08-23 11:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-09 10:56 [RFC] [GIT PATCH] IPv6 Routing / Ndisc Fixes YOSHIFUJI Hideaki / 吉藤英明
     [not found] ` <44D9D431.10101@tcs.hut.fi>
2006-08-09 21:37   ` Ville Nuorvala
2006-08-10  8:46     ` YOSHIFUJI Hideaki / 吉藤英明
2006-08-10 10:20       ` Ville Nuorvala
2006-08-10 12:07         ` Possible leak of multicast source filter sctructure Michal Ruzicka
2006-08-10 12:12           ` David Miller
2006-08-10 12:13             ` David Miller
2006-08-10 18:07           ` David Stevens
2006-08-23 11:08           ` Michal Ruzicka [this message]
2006-08-23 12:32             ` multicast group memberships purge on interface delete jamal
2006-08-23 13:29               ` Michal Růžička
2006-08-23 14:48                 ` jamal
2006-08-23 18:51             ` David Stevens
2006-08-24  0:40       ` [RFC] [GIT PATCH] IPv6 Routing / Ndisc Fixes David Miller
     [not found]   ` <44DA274C.30205@tcs.hut.fi>
2006-08-10  0:05     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='021e01c6c6a4$6e7845f0$2303a8c0@mruzicka' \
    --to=michal.ruzicka@comstar.cz \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox