public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michal Růžička" <michal.ruzicka@comstar.cz>
To: <hadi@cyberus.ca>
Cc: <netdev@vger.kernel.org>
Subject: Re: multicast group memberships purge on interface delete
Date: Wed, 23 Aug 2006 15:29:45 +0200	[thread overview]
Message-ID: <039601c6c6b8$47b0f7a0$2303a8c0@mruzicka> (raw)
In-Reply-To: 1156336331.5035.79.camel@jzny2


>
> You should be able to "fix it" in the kernel by listening to events of
> the interface/device disappearing.

Interesting, I've thought that it would have to be done explicitly by the 
interface
cleanup code, this approach looks promising to me.

> By "disappearing" i think you meant
> the netdevice was totally rmmod-ed?

No need to rmmod anything, just think of ppp or gre interfaces which come 
and go
without any modules loading/unloading. But yes, the rmmod would probably be
needed in case of, for example, an ethernet device.

> The challenge is to make the app
> also aware of you taking away the group from underneath them (thats why
> i said "fix it")
>

I dont's see this as any challange as the applications could just assume 
that any
memberships on deleted interfaces have been just droped implicitly by the 
kernel.
(This should be no problem for them provided that they keep track of
the interfaces present on the system, which they should anyway or otherwise
they could end up listening to just a part of the multicast traffic they are
interested in.)

>
> These events are also available in user space via netlink. so an alter
> your app could listen to them and make the group leaves instead of the
> kernel.
>

In fact I've had proposed that on the application mailing list (the 
appliaction is
quagga formerly zebra routing suite to be specific) but the people there 
disliked
it because of the fact that for example the NetBSD (as I noted in my 
previous
post) does the group leaves implicitly on the interface delete and the 
explicit
group leaves fail there (and reportedly on other OSes too).
Sure this can solved by some conditional compilation.
This is why my post was more a theoretical design question/suggestion than
a feature request (or a bug report).

In this sense what do you think about the possible benefit of the proposed
approach for maintaning the per-interface multicast reception state?

> cheers,
> jamal
>

Thanks
Michal 


  reply	other threads:[~2006-08-23 13:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-09 10:56 [RFC] [GIT PATCH] IPv6 Routing / Ndisc Fixes YOSHIFUJI Hideaki / 吉藤英明
     [not found] ` <44D9D431.10101@tcs.hut.fi>
2006-08-09 21:37   ` Ville Nuorvala
2006-08-10  8:46     ` YOSHIFUJI Hideaki / 吉藤英明
2006-08-10 10:20       ` Ville Nuorvala
2006-08-10 12:07         ` Possible leak of multicast source filter sctructure Michal Ruzicka
2006-08-10 12:12           ` David Miller
2006-08-10 12:13             ` David Miller
2006-08-10 18:07           ` David Stevens
2006-08-23 11:08           ` multicast group memberships purge on interface delete Michal Ruzicka
2006-08-23 12:32             ` jamal
2006-08-23 13:29               ` Michal Růžička [this message]
2006-08-23 14:48                 ` jamal
2006-08-23 18:51             ` David Stevens
2006-08-24  0:40       ` [RFC] [GIT PATCH] IPv6 Routing / Ndisc Fixes David Miller
     [not found]   ` <44DA274C.30205@tcs.hut.fi>
2006-08-10  0:05     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='039601c6c6b8$47b0f7a0$2303a8c0@mruzicka' \
    --to=michal.ruzicka@comstar.cz \
    --cc=hadi@cyberus.ca \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox