Re: [PATCH net-next v2 1/5] net: devlink: turn devlink into a built-in

[Florian Fainelli <f.fainelli@gmail.com>]

On 2/22/19 11:54 AM, Jakub Kicinski wrote:
> Being able to build devlink as a module causes growing pains.
> First all drivers had to add a meta dependency to make sure
> they are not built in when devlink is built as a module.  Now
> we are struggling to invoke ethtool compat code reliably.
> 
> Make devlink code built-in, users can still not build it at
> all but the dynamically loadable module option is removed.

One use case I was potentially thinking about was that you have to load
devlink at some point to e.g.: recover your device from an initramfs,
and then you don't use devlink anymore so just you rmmod it and you have
switched to a different filesystem entirely (possibly on the network
that you just helped recover). That sounds like a corner case though so:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian