From: Jonas Karlman <jonas@kwiboo.se>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, "Yao Zi" <ziyao@disroot.org>,
"Chukun Pan" <amadeus@jmu.edu.cn>,
"Heiko Stuebner" <heiko@sntech.de>,
netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: dsa: realtek: Add support for use of an optional mdio node
Date: Mon, 28 Jul 2025 18:14:37 +0200 [thread overview]
Message-ID: <030aff6c-531b-4be3-9176-83fcff21d539@kwiboo.se> (raw)
In-Reply-To: <2f942223-8683-4808-8f7a-4f46e18f402d@lunn.ch>
Hi Andrew,
On 7/28/2025 5:40 PM, Andrew Lunn wrote:
>> When it comes to having the switch being described as an interrupt
>> controller in the DT is also very wrong, the switch only consume a
>> single HW interrupt. The fact that the driver creates virtual irq for
>> each port is purely a software construct and is not something that
>> should be reflected in the DT.
>
> I think that is not always clear cut. Switches can be considered SoC
> of their own. They have multiple hardware blocks, which can be
> described independent, just like a traditional SoC and its .dtsi
> file. The switch blocks can then be connected together in the same way
> SoCs are.
I guess you are correct, thanks for clarifying this :-)
> I've not looked at this particular switch driver, but the Marvell
> switches have a similar single interrupt output pin connected to the
> host SoC. Within the switch, there are at least two cascaded interrupt
> controllers. We implement standard Linux interrupt controllers for
> these. That allows us to use standard DT properties to link the
> internal PHY interrupts to these interrupt controllers.
Makes sense, I will describe the phy interrupts of the switch in a v2.
Regards,
Jonas
>
> Andrew
next prev parent reply other threads:[~2025-07-28 16:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-27 18:02 [PATCH net-next 0/3] net: dsa: realtek: Add support for use of an optional mdio node Jonas Karlman
2025-07-27 18:02 ` [PATCH net-next 1/3] net: dsa: realtek: remove unused user_mii_bus from realtek_priv Jonas Karlman
2025-07-27 18:02 ` [PATCH net-next 2/3] net: dsa: realtek: Add support for use of an optional mdio node Jonas Karlman
2025-07-27 19:09 ` Andrew Lunn
2025-07-27 21:52 ` Jonas Karlman
2025-07-27 22:09 ` Andrew Lunn
2025-07-28 15:24 ` Jonas Karlman
2025-07-28 15:40 ` Andrew Lunn
2025-07-28 16:14 ` Jonas Karlman [this message]
2025-07-27 18:03 ` [PATCH 3/3] arm64: dts: rockchip: Add RTL8367RB-VB switch to Radxa E24C Jonas Karlman
2025-07-27 19:16 ` Andrew Lunn
2025-07-28 14:57 ` Jonas Karlman
2025-07-27 19:57 ` Russell King (Oracle)
2025-07-28 14:30 ` Chukun Pan
2025-07-28 17:47 ` Jonas Karlman
2025-07-29 11:50 ` Chukun Pan
2025-07-29 20:55 ` Jonas Karlman
2025-07-29 21:44 ` Andrew Lunn
2025-08-10 14:01 ` Chukun Pan
2025-08-10 15:15 ` Andrew Lunn
2025-08-10 16:49 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=030aff6c-531b-4be3-9176-83fcff21d539@kwiboo.se \
--to=jonas@kwiboo.se \
--cc=alsi@bang-olufsen.dk \
--cc=amadeus@jmu.edu.cn \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=heiko@sntech.de \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox