Netdev List
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Jiri Pirko <jiri@resnulli.us>,
	Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: Re: [PATCH net] sch_hhf: fix null pointer dereference on init failure
Date: Wed, 30 Aug 2017 10:27:20 +0300	[thread overview]
Message-ID: <04bea369-e2d9-954a-0da0-eb3ff831a1c7@cumulusnetworks.com> (raw)
In-Reply-To: <CAM_iQpWN6bubnnFfqoZeiuH5NF3tpQ7nb91CBp09Yw-NJzRcng@mail.gmail.com>

On 30/08/17 04:24, Cong Wang wrote:
> On Tue, Aug 29, 2017 at 12:02 PM, Nikolay Aleksandrov
> <nikolay@cumulusnetworks.com> wrote:
>> First I did it with the check in the for () conditional, but this is more
>> visible and explicit. Let me know if you'd like the shorter version. :-)
> 
> Or, if you want to make the patch size smaller, just check NULL
> before for():
> 
> if (!q->hh_flows)
>     return;
> 
> for (...)
> 
> Up to you, I have no strong opinion here, slightly prefer a smaller
> one for backport.
> 

Sure, either one is fine with me too. Since I'll be resubmitting these in a set
I'll use the smaller version for this one.

Thanks,
 Nik

      reply	other threads:[~2017-08-30  7:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 19:02 [PATCH net] sch_hhf: fix null pointer dereference on init failure Nikolay Aleksandrov
2017-08-29 19:46 ` Nikolay Aleksandrov
2017-08-30  1:24 ` Cong Wang
2017-08-30  7:27   ` Nikolay Aleksandrov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04bea369-e2d9-954a-0da0-eb3ff831a1c7@cumulusnetworks.com \
    --to=nikolay@cumulusnetworks.com \
    --cc=edumazet@google.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox