Netdev List
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: netdev@vger.kernel.org
Cc: edumazet@google.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
	jiri@resnulli.us, roopa@cumulusnetworks.com
Subject: Re: [PATCH net] sch_hhf: fix null pointer dereference on init failure
Date: Tue, 29 Aug 2017 22:46:40 +0300	[thread overview]
Message-ID: <b89785c3-d97d-3153-72ea-c0c22160d655@cumulusnetworks.com> (raw)
In-Reply-To: <1504033335-19098-1-git-send-email-nikolay@cumulusnetworks.com>

On 29/08/17 22:02, Nikolay Aleksandrov wrote:
> If sch_hhf fails in its ->init() function (either due to wrong
> user-space arguments as below or memory alloc failure of hh_flows) it
> will do a null pointer deref of q->hh_flows in its ->destroy() function.
> 
> To reproduce the crash:
> $ tc qdisc add dev eth0 root hhf quantum 2000000 non_hh_weight 10000000
> 

Uh, sorry about sending these out separately. I'll send the rest as a set for
easier review once I test them, should be just a couple more.

  reply	other threads:[~2017-08-29 19:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 19:02 [PATCH net] sch_hhf: fix null pointer dereference on init failure Nikolay Aleksandrov
2017-08-29 19:46 ` Nikolay Aleksandrov [this message]
2017-08-30  1:24 ` Cong Wang
2017-08-30  7:27   ` Nikolay Aleksandrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b89785c3-d97d-3153-72ea-c0c22160d655@cumulusnetworks.com \
    --to=nikolay@cumulusnetworks.com \
    --cc=edumazet@google.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox