From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Saeed Mahameed <saeedm@mellanox.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Or Gerlitz <ogerlitz@mellanox.com>
Subject: Re: [net 7/8] net/mlx5e: Avoid using the ipv6 stub in the TC offload neigh update path
Date: Sat, 24 Mar 2018 12:52:18 +0300 [thread overview]
Message-ID: <053eef8f-a218-27d2-df75-e49289a4c3d3@cogentembedded.com> (raw)
In-Reply-To: <20180323220534.19353-8-saeedm@mellanox.com>
Hello!
On 3/24/2018 1:05 AM, Saeed Mahameed wrote:
> From: Or Gerlitz <ogerlitz@mellanox.com>
>
> Currently we use the global ipv6_stub var to access the ipv6 global
> nd table. This practice gets us to troubles when the stub is only partially
> set e.g when ipv6 is loaded under the disabled policy. In this case, as of commit
> 343d60aada5a "ipv6: change ipv6_stub_impl.ipv6_dst_lookup to take net argument"
The summary line must be enclosed in (""), not just "".
> the stub is not null, but stub->nd_tbl is and we crash.
>
> As we can access directly the ipv6 nd_tbl, the fix is just avoid the
As we can access the ipv6 nd_tbl directly, the fix is just to avoid the
> reference through the stub. There is one place in the code were we
^^^^
Where?
> issue ipv6 route lookup and keep doing it through the stub, but that
> mentioned commit makes sure we get -EAFNOSUPPORT from the stack.
>
> Fixes: 232c001398ae ('net/mlx5e: Add support to neighbour update flow')
("") here as well.
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
> Reviewed-by: Aviv Heller <avivh@mellanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2018-03-24 9:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 22:05 [pull request][net 0/8] Mellanox, mlx5 fixes 2018-03-23 Saeed Mahameed
2018-03-23 22:05 ` [net 1/8] net/mlx5e: Don't override vport admin link state in switchdev mode Saeed Mahameed
2018-03-23 22:05 ` [net 2/8] net/mlx5e: Use 32 bits to store VF representor SQ number Saeed Mahameed
2018-03-23 22:05 ` [net 3/8] net/mlx5: Make eswitch support to depend on switchdev Saeed Mahameed
2018-03-23 22:05 ` [net 4/8] net/mlx5e: Verify coalescing parameters in range Saeed Mahameed
2018-03-23 22:05 ` [net 5/8] net/mlx5e: Fix traffic being dropped on VF representor Saeed Mahameed
2018-03-23 22:05 ` [net 6/8] net/mlx5e: Fix memory usage issues in offloading TC flows Saeed Mahameed
2018-03-23 22:05 ` [net 7/8] net/mlx5e: Avoid using the ipv6 stub in the TC offload neigh update path Saeed Mahameed
2018-03-24 9:52 ` Sergei Shtylyov [this message]
2018-03-23 22:05 ` [net 8/8] net/mlx5e: Sync netdev vxlan ports at open Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=053eef8f-a218-27d2-df75-e49289a4c3d3@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox