* [net-next] fjes: remove duplicate set of flag IFF_BROADCAST
@ 2017-06-13 12:49 Zhang Shengju
2017-06-13 15:55 ` Sergei Shtylyov
2017-06-13 17:55 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Zhang Shengju @ 2017-06-13 12:49 UTC (permalink / raw)
To: davem, izumi.taku, netdev
Remove unnecessary set of flag IFF_BROADCAST, since ether_setup
already does this.
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
---
drivers/net/fjes/fjes_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index ae48c80..b56e07f 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -1348,7 +1348,6 @@ static void fjes_netdev_setup(struct net_device *netdev)
netdev->mtu = fjes_support_mtu[3];
netdev->min_mtu = fjes_support_mtu[0];
netdev->max_mtu = fjes_support_mtu[3];
- netdev->flags |= IFF_BROADCAST;
netdev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net-next] fjes: remove duplicate set of flag IFF_BROADCAST
2017-06-13 12:49 [net-next] fjes: remove duplicate set of flag IFF_BROADCAST Zhang Shengju
@ 2017-06-13 15:55 ` Sergei Shtylyov
2017-06-13 17:55 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2017-06-13 15:55 UTC (permalink / raw)
To: Zhang Shengju, davem, izumi.taku, netdev
Hello!
On 06/13/2017 03:49 PM, Zhang Shengju wrote:
> Remove unnecessary set of flag IFF_BROADCAST, since ether_setup
s/set/setting/. Perhaps can be fixed while applying...
> already does this.
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [net-next] fjes: remove duplicate set of flag IFF_BROADCAST
2017-06-13 12:49 [net-next] fjes: remove duplicate set of flag IFF_BROADCAST Zhang Shengju
2017-06-13 15:55 ` Sergei Shtylyov
@ 2017-06-13 17:55 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-06-13 17:55 UTC (permalink / raw)
To: zhangshengju; +Cc: izumi.taku, netdev
From: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Date: Tue, 13 Jun 2017 20:49:49 +0800
> Remove unnecessary set of flag IFF_BROADCAST, since ether_setup
> already does this.
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Applied with commit log message fixed, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-13 17:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-13 12:49 [net-next] fjes: remove duplicate set of flag IFF_BROADCAST Zhang Shengju
2017-06-13 15:55 ` Sergei Shtylyov
2017-06-13 17:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox