From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ido Schimmel <idosch@mellanox.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, dsahern@gmail.com, eric.dumazet@gmail.com,
Thomas.Winter@alliedtelesis.co.nz, mlxsw@mellanox.com
Subject: Re: [PATCH net] ipv6: Revert "ipv6: Allow non-gateway ECMP for IPv6"
Date: Wed, 2 May 2018 12:50:18 -0700 [thread overview]
Message-ID: <06ce7e15-92f3-116a-21d0-5090f33ce845@gmail.com> (raw)
In-Reply-To: <20180502194156.9275-1-idosch@mellanox.com>
On 05/02/2018 12:41 PM, Ido Schimmel wrote:
> This reverts commit edd7ceb78296 ("ipv6: Allow non-gateway ECMP for
> IPv6").
>
> Eric reported a division by zero in rt6_multipath_rebalance() which is
> caused by above commit that considers identical local routes to be
> siblings. The division by zero happens because a nexthop weight is not
> set for local routes.
>
> Revert the commit as it does not fix a bug and has side effects.
>
> To reproduce:
>
> # ip -6 address add 2001:db8::1/64 dev dummy0
> # ip -6 address add 2001:db8::1/64 dev dummy1
>
> Fixes: edd7ceb78296 ("ipv6: Allow non-gateway ECMP for IPv6")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
Tested-by: Eric Dumazet <edumazet@google.com>
Thanks for fixing this !
next prev parent reply other threads:[~2018-05-02 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 19:41 [PATCH net] ipv6: Revert "ipv6: Allow non-gateway ECMP for IPv6" Ido Schimmel
2018-05-02 19:50 ` Eric Dumazet [this message]
2018-05-02 20:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06ce7e15-92f3-116a-21d0-5090f33ce845@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=Thomas.Winter@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox