From: Davide Caratti <dcaratti@redhat.com>
To: Roman Mashak <mrv@mojatatu.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH v2 net-next 0/6] net sched actions: code style cleanup and fixes
Date: Thu, 28 Jun 2018 14:26:38 +0200 [thread overview]
Message-ID: <0bc7c30bc912bfa28da4af6c2c5525cb8c5acf8f.camel@redhat.com> (raw)
In-Reply-To: <1530120815-13736-1-git-send-email-mrv@mojatatu.com>
On Wed, 2018-06-27 at 13:33 -0400, Roman Mashak wrote:
> The patchset fixes a few code stylistic issues and typos, as well as one
> detected by sparse semantic checker tool.
>
> No functional changes introduced.
>
> Patch 1 & 2 fix coding style bits caught by the checkpatch.pl script
> Patch 3 fixes an issue with a shadowed variable
> Patch 4 adds sizeof() operator instead of magic number for buffer length
> Patch 5 fixes typos in diagnostics messages
> Patch 6 explicitly sets unsigned char for bitwise operation
>
> v2:
> - submit for net-next
> - added Reviewed-by tags
> - use u8* instead of char* as per Davide Caratti suggestion
>
> Roman Mashak (6):
> net sched actions: fix coding style in pedit action
> net sched actions: fix coding style in pedit headers
> net sched actions: fix sparse warning
> net sched actions: use sizeof operator for buffer length
> net sched actions: fix misleading text strings in pedit action
> net sched actions: avoid bitwise operation on signed value in pedit
>
> include/net/tc_act/tc_pedit.h | 1 +
> include/uapi/linux/tc_act/tc_pedit.h | 9 ++++++--
> net/sched/act_pedit.c | 43 +++++++++++++++++++-----------------
> 3 files changed, 31 insertions(+), 22 deletions(-)
>
for the series:
Acked-by: Davide Caratti <dcaratti@redhat.com>
regards,
--
davide
next prev parent reply other threads:[~2018-06-28 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 17:33 [PATCH v2 net-next 0/6] net sched actions: code style cleanup and fixes Roman Mashak
2018-06-27 17:33 ` [PATCH v2 net-next 1/6] net sched actions: fix coding style in pedit action Roman Mashak
2018-06-27 17:33 ` [PATCH v2 net-next 2/6] net sched actions: fix coding style in pedit headers Roman Mashak
2018-06-27 17:33 ` [PATCH v2 net-next 3/6] net sched actions: fix sparse warning Roman Mashak
2018-06-27 17:33 ` [PATCH v2 net-next 4/6] net sched actions: use sizeof operator for buffer length Roman Mashak
2018-06-27 17:33 ` [PATCH v2 net-next 5/6] net sched actions: fix misleading text strings in pedit action Roman Mashak
2018-06-27 17:33 ` [PATCH v2 net-next 6/6] net sched actions: avoid bitwise operation on signed value in pedit Roman Mashak
2018-06-28 12:26 ` Davide Caratti [this message]
2018-06-28 13:12 ` [PATCH v2 net-next 0/6] net sched actions: code style cleanup and fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc7c30bc912bfa28da4af6c2c5525cb8c5acf8f.camel@redhat.com \
--to=dcaratti@redhat.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox