public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: shaozhengchao <shaozhengchao@huawei.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: selftests/tc-testings cgroup.json test failed
Date: Wed, 7 Jun 2023 18:46:34 +0800	[thread overview]
Message-ID: <0e4a9752-ab3e-07cd-e030-45f230481d0b@huawei.com> (raw)
In-Reply-To: <ZIBT2d9U9/pdR/gc@Laptop-X1>



On 2023/6/7 17:54, Hangbin Liu wrote:
> Hi Zhengchao,
> 
> I tried run cgroup.json (and flow.json) with linux 6.3 and iproute 6.3.
> But almost test failed. e.g.
> 
> All test results:
> 
> 1..56
> not ok 1 6273 - Add cgroup filter with cmp ematch u8/link layer and drop action
>          Could not match regex pattern. Verify command output:
> filter protocol ip pref 1 cgroup chain 0
> filter protocol ip pref 1 cgroup chain 0 handle 0x1
>          action order 1: gact action drop
>           random type none pass val 0
>           index 1 ref 1 bind 1
> 
> 
> not ok 2 4721 - Add cgroup filter with cmp ematch u8/link layer with trans flag and pass action
>          Could not match regex pattern. Verify command output:
> filter protocol ip pref 1 cgroup chain 0
> filter protocol ip pref 1 cgroup chain 0 handle 0x1
>          action order 1: gact action pass
>           random type none pass val 0
>           index 1 ref 1 bind 1
> 
> 
> I saw the matchPattern checks ".*cmp..." which is not exist with my tc output.
> 
> "matchPattern": "^filter protocol ip pref [0-9]+ cgroup chain [0-9]+.*handle 0x1.*cmp\\(u8 at 0 layer 0 mask 0xff gt 10\\)",
> 
> So which tc version are you using? Am I missed something?
>
Hi Hangbin:
	I upgraded iproute to 6.3.0 locally, and these test cases are
successfully executed. My kernel version is 6.4.0 and OS version is
ubuntu 1804 LTS. I am wondering if it had something to do with the OS?

Zhengchao Shao

> Thanks
> Hangbin

  reply	other threads:[~2023-06-07 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-07  9:54 selftests/tc-testings cgroup.json test failed Hangbin Liu
2023-06-07 10:46 ` shaozhengchao [this message]
2023-06-08  2:29   ` Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e4a9752-ab3e-07cd-e030-45f230481d0b@huawei.com \
    --to=shaozhengchao@huawei.com \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox