selftests/tc-testings cgroup.json test failed

selftests/tc-testings cgroup.json test failed

[Hangbin Liu]

Hi Zhengchao,

I tried run cgroup.json (and flow.json) with linux 6.3 and iproute 6.3.
But almost test failed. e.g.

All test results:

1..56
not ok 1 6273 - Add cgroup filter with cmp ematch u8/link layer and drop action
        Could not match regex pattern. Verify command output:
filter protocol ip pref 1 cgroup chain 0
filter protocol ip pref 1 cgroup chain 0 handle 0x1
        action order 1: gact action drop
         random type none pass val 0
         index 1 ref 1 bind 1


not ok 2 4721 - Add cgroup filter with cmp ematch u8/link layer with trans flag and pass action
        Could not match regex pattern. Verify command output:
filter protocol ip pref 1 cgroup chain 0
filter protocol ip pref 1 cgroup chain 0 handle 0x1
        action order 1: gact action pass
         random type none pass val 0
         index 1 ref 1 bind 1


I saw the matchPattern checks ".*cmp..." which is not exist with my tc output.

"matchPattern": "^filter protocol ip pref [0-9]+ cgroup chain [0-9]+.*handle 0x1.*cmp\\(u8 at 0 layer 0 mask 0xff gt 10\\)",

So which tc version are you using? Am I missed something?

Thanks
Hangbin

Re: selftests/tc-testings cgroup.json test failed

[shaozhengchao]

On 2023/6/7 17:54, Hangbin Liu wrote:
> Hi Zhengchao,
> 
> I tried run cgroup.json (and flow.json) with linux 6.3 and iproute 6.3.
> But almost test failed. e.g.
> 
> All test results:
> 
> 1..56
> not ok 1 6273 - Add cgroup filter with cmp ematch u8/link layer and drop action
>          Could not match regex pattern. Verify command output:
> filter protocol ip pref 1 cgroup chain 0
> filter protocol ip pref 1 cgroup chain 0 handle 0x1
>          action order 1: gact action drop
>           random type none pass val 0
>           index 1 ref 1 bind 1
> 
> 
> not ok 2 4721 - Add cgroup filter with cmp ematch u8/link layer with trans flag and pass action
>          Could not match regex pattern. Verify command output:
> filter protocol ip pref 1 cgroup chain 0
> filter protocol ip pref 1 cgroup chain 0 handle 0x1
>          action order 1: gact action pass
>           random type none pass val 0
>           index 1 ref 1 bind 1
> 
> 
> I saw the matchPattern checks ".*cmp..." which is not exist with my tc output.
> 
> "matchPattern": "^filter protocol ip pref [0-9]+ cgroup chain [0-9]+.*handle 0x1.*cmp\\(u8 at 0 layer 0 mask 0xff gt 10\\)",
> 
> So which tc version are you using? Am I missed something?
>
Hi Hangbin:
	I upgraded iproute to 6.3.0 locally, and these test cases are
successfully executed. My kernel version is 6.4.0 and OS version is
ubuntu 1804 LTS. I am wondering if it had something to do with the OS?

Zhengchao Shao

> Thanks
> Hangbin

Re: selftests/tc-testings cgroup.json test failed

[Hangbin Liu]

On Wed, Jun 07, 2023 at 06:46:34PM +0800, shaozhengchao wrote:
> > I saw the matchPattern checks ".*cmp..." which is not exist with my tc output.
> > 
> > "matchPattern": "^filter protocol ip pref [0-9]+ cgroup chain [0-9]+.*handle 0x1.*cmp\\(u8 at 0 layer 0 mask 0xff gt 10\\)",
> > 
> > So which tc version are you using? Am I missed something?
> > 
> Hi Hangbin:
> 	I upgraded iproute to 6.3.0 locally, and these test cases are
> successfully executed. My kernel version is 6.4.0 and OS version is
> ubuntu 1804 LTS. I am wondering if it had something to do with the OS?

Ah, I checked the source code and found my OS didn't enable
CONFIG_NET_EMATCH_CMP.

Thanks
Hangbin