Re: [PATCH v3 2/4] net: qrtr: Assign unique node id for MHI endpoints

[Marcel Holtmann <marcel@holtmann.org>]

Hi Mani,

>>>>> +#define QRTR_NODE_HOST_BASE 0x10000u
>>>> 
>>>> Can it be exposed with include/uapi/linux/qrtr.h also. There are user space clients like modem manager
>>>> which need to calculate modified node id to distinguish same service from multi modem over mhi.
>>>> This is same as wlan use case.
>>> 
>>> did anybody actually looked at the proposal that Denis and I came up with. It was exactly addressing this properly.
>>> 
>>> It seems you guys came up with some hot fix and want to run with it. After month and month of silence and not bothering to review the proposal, you are trying to push your thing?
>>> 
>>> If you don’t support userspace, your proposal is broken. Plain and simple.
>> 
>> I'm still willing to submit a new version of that patchset originally by
>> Denis, if the kernel devs so decide that it's the way. For example, the
>> "radix tree of radix trees" approach could be replaced with a hash
>> table.
>> 
>> There was also some criticism about a layering violation in storing the
>> endpoint id to mhi controller. However, maybe that could be reduced by
>> providing a correct abstraction around it, so that other code doesn't
>> touch the mhi controller structure directly.
>> 
>> Other criticism for that patchset by Denis was its overt complexity.
>> Yes, it has more lines of code changed.
>> 
>> This dual-card setup needs to be handled somehow, either by Denis's
>> patchset or by Manivannan's patchset.
>> 
> 
> I wish to go ahead with my series as it is simple and tested across the
> multi-WLAN setups. For concern around exposing the nid to userspace, I'll
> implement it in next version, thanks!

actually no. Seems you have no plan on how to address the userspace problem.

It would be useful to actually review the endpoint_id concept introduced by Denis since it has a userspace facing API. What is your plan? Are you planning to break all existing userspace code?

Regards

Marcel