From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Ido Schimmel <idosch@idosch.org>, Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/2] net: plumb extack in __dev_change_net_namespace()
Date: Thu, 20 Feb 2025 14:22:15 +0100 [thread overview]
Message-ID: <101c5d62-d1e9-4ac4-a254-5aeafeac6033@6wind.com> (raw)
In-Reply-To: <CANn89iKdYXKqePQ5g5eU9UGuTi4fZaxwWy2BK7D+F2wkQHAXhg@mail.gmail.com>
Le 20/02/2025 à 14:17, Eric Dumazet a écrit :
> On Thu, Feb 20, 2025 at 2:03 PM Nicolas Dichtel
> <nicolas.dichtel@6wind.com> wrote:
>>
>> It could be hard to understand why the netlink command fails. For example,
>> if dev->netns_local is set, the error is "Invalid argument".
>>
>
> After your patch, a new message is : " "The interface has the 'netns
> local' property""
>
> Honestly, I am not sure we export to user space the concept of 'netns local'
>
> "This interface netns is not allowed to be changed" or something like that ?
Frankly, I was hesitating. I used 'netns local' to ease the link with the new
netlink attribute, and with what was displayed by ethtool for a long time.
I don't have a strong opinion about this.
next prev parent reply other threads:[~2025-02-20 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 13:02 [PATCH net-next v3 0/2] net: notify users when an iface cannot change its netns Nicolas Dichtel
2025-02-20 13:02 ` [PATCH net-next v3 1/2] net: advertise 'netns local' property via netlink Nicolas Dichtel
2025-02-20 13:10 ` Eric Dumazet
2025-02-20 15:34 ` Alexander Lobakin
2025-02-21 4:23 ` Kuniyuki Iwashima
2025-02-20 13:02 ` [PATCH net-next v3 2/2] net: plumb extack in __dev_change_net_namespace() Nicolas Dichtel
2025-02-20 13:17 ` Eric Dumazet
2025-02-20 13:22 ` Nicolas Dichtel [this message]
2025-02-20 13:24 ` Eric Dumazet
2025-02-20 15:11 ` Nicolas Dichtel
2025-02-21 4:34 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=101c5d62-d1e9-4ac4-a254-5aeafeac6033@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox