Netdev List
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	Ido Schimmel <idosch@idosch.org>, Andrew Lunn <andrew@lunn.ch>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v3 1/2] net: advertise 'netns local' property via netlink
Date: Thu, 20 Feb 2025 16:34:59 +0100	[thread overview]
Message-ID: <300eefd4-2813-429a-b853-601518e20d98@intel.com> (raw)
In-Reply-To: <20250220130334.3583331-2-nicolas.dichtel@6wind.com>

From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Thu, 20 Feb 2025 14:02:35 +0100

> Since commit 05c1280a2bcf ("netdev_features: convert NETIF_F_NETNS_LOCAL to
> dev->netns_local"), there is no way to see if the netns_local property is
> set on a device. Let's add a netlink attribute to advertise it.
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

Meh, I was sure nobody looks at those read-only Ethtool "features"...

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
>  Documentation/netlink/specs/rt_link.yaml | 3 +++
>  include/uapi/linux/if_link.h             | 1 +
>  net/core/rtnetlink.c                     | 3 +++
>  3 files changed, 7 insertions(+)

Thanks,
Olek

  parent reply	other threads:[~2025-02-20 15:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20 13:02 [PATCH net-next v3 0/2] net: notify users when an iface cannot change its netns Nicolas Dichtel
2025-02-20 13:02 ` [PATCH net-next v3 1/2] net: advertise 'netns local' property via netlink Nicolas Dichtel
2025-02-20 13:10   ` Eric Dumazet
2025-02-20 15:34   ` Alexander Lobakin [this message]
2025-02-21  4:23   ` Kuniyuki Iwashima
2025-02-20 13:02 ` [PATCH net-next v3 2/2] net: plumb extack in __dev_change_net_namespace() Nicolas Dichtel
2025-02-20 13:17   ` Eric Dumazet
2025-02-20 13:22     ` Nicolas Dichtel
2025-02-20 13:24       ` Eric Dumazet
2025-02-20 15:11         ` Nicolas Dichtel
2025-02-21  4:34           ` Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=300eefd4-2813-429a-b853-601518e20d98@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=idosch@idosch.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox