From: Alexei Starovoitov <ast@fb.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Song Liu <songliubraving@fb.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v4 bpf-next 0/2] bpf: add cg_skb_is_valid_access
Date: Fri, 19 Oct 2018 01:46:40 +0000 [thread overview]
Message-ID: <106cc871-ece8-7278-6b4b-1b1946f9a949@fb.com> (raw)
In-Reply-To: <20181018233403.xnea2m7ntwxue44r@ast-mbp.dhcp.thefacebook.com>
On 10/18/18 4:34 PM, Alexei Starovoitov wrote:
> On Thu, Oct 18, 2018 at 09:06:47AM -0700, Song Liu wrote:
>> Changes v3 -> v4:
>> 1. Fixed crash issue reported by Alexei.
>>
>> Changes v2 -> v3:
>> 1. Added helper function bpf_compute_and_save_data_pointers() and
>> bpf_restore_data_pointers().
>>
>> Changes v1 -> v2:
>> 1. Updated the list of read-only fields, and read-write fields.
>> 2. Added dummy sk to bpf_prog_test_run_skb().
>>
>> This set enables BPF program of type BPF_PROG_TYPE_CGROUP_SKB to access
>> some __skb_buff data directly.
>
> Applied, Thanks
Daniel brought up good point re: data_meta. Let's address it one way
or the other and respin the series instead of adding follow up patches.
So I tossed this series out of bpf-next.
prev parent reply other threads:[~2018-10-19 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 16:06 [PATCH v4 bpf-next 0/2] bpf: add cg_skb_is_valid_access Song Liu
2018-10-18 16:06 ` [PATCH v4 bpf-next 1/2] bpf: add cg_skb_is_valid_access for BPF_PROG_TYPE_CGROUP_SKB Song Liu
2018-10-19 0:14 ` Daniel Borkmann
2018-10-19 1:33 ` Alexei Starovoitov
2018-10-19 2:03 ` Alexei Starovoitov
2018-10-18 16:06 ` [PATCH v4 bpf-next 2/2] bpf: add tests for direct packet access from CGROUP_SKB Song Liu
2018-10-18 23:34 ` [PATCH v4 bpf-next 0/2] bpf: add cg_skb_is_valid_access Alexei Starovoitov
2018-10-19 1:46 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=106cc871-ece8-7278-6b4b-1b1946f9a949@fb.com \
--to=ast@fb.com \
--cc=Kernel-team@fb.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox