[RFC/PATCH][Bonding]: keep slave state when admin down

[RFC/PATCH][Bonding]: keep slave state when admin down

[jamal]

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]


When a bonding netdevice is admin-ed down it looses the slaves
attributes (set via ifenslave). This is not consistent with other
behavior of netdevices (example a qdisc attached to a netdevice doesnt
disappear or an attached IP address etc).
The included patch fixes this. Ive tested by ifenslaving, downing the
bond, checking /proc and making sure it still has the slaves, up-ing the
bond and making sure things continue to work.

Jay/Bonding folks if you are ok with it, just ACK it or include it in
your tree etc. Otherwise we can discuss. This is against linus tree.

cheers,
jamal

[-- Attachment #2: bond_p2 --]
[-- Type: text/x-patch, Size: 941 bytes --]

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 8b95123..df319be 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -3420,7 +3420,6 @@ static int bond_close(struct net_device 
 
 	write_lock_bh(&bond->lock);
 
-	bond_mc_list_destroy(bond);
 
 	/* signal timers not to re-arm */
 	bond->kill_timers = 1;
@@ -3451,8 +3450,6 @@ static int bond_close(struct net_device 
 		break;
 	}
 
-	/* Release the bonded slaves */
-	bond_release_all(bond_dev);
 
 	if ((bond->params.mode == BOND_MODE_TLB) ||
 	    (bond->params.mode == BOND_MODE_ALB)) {
@@ -4237,6 +4234,9 @@ static void bond_free_all(void)
 	list_for_each_entry_safe(bond, nxt, &bond_dev_list, bond_list) {
 		struct net_device *bond_dev = bond->dev;
 
+		bond_mc_list_destroy(bond);
+		/* Release the bonded slaves */
+		bond_release_all(bond_dev);
 		unregister_netdevice(bond_dev);
 		bond_deinit(bond_dev);
 	}

Re: [RFC/PATCH][Bonding]: keep slave state when admin down

[Jay Vosburgh]

jamal <hadi@cyberus.ca> wrote:

>When a bonding netdevice is admin-ed down it looses the slaves
>attributes (set via ifenslave). This is not consistent with other
>behavior of netdevices (example a qdisc attached to a netdevice doesnt
>disappear or an attached IP address etc).
>The included patch fixes this. Ive tested by ifenslaving, downing the
>bond, checking /proc and making sure it still has the slaves, up-ing the
>bond and making sure things continue to work.

	Do the initscript and sysconfig packages (/sbin/ifup, ifdown,
that stuff in /etc/sysconfig/network-scripts, etc) do the right thing
with this change?

	If memory serves, the initscripts will down the bond during
setup; I'm not sure if there is any dependency on that action releasing
all (possibly preexisting) slaves.

	I don't have a big problem with this, but I'm a little concerned
that there may be dependencies on the existing behavior.

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com

Re: [RFC/PATCH][Bonding]: keep slave state when admin down

[jamal]

On Thu, 2006-20-07 at 11:50 -0700, Jay Vosburgh wrote:

> 
> 	Do the initscript and sysconfig packages (/sbin/ifup, ifdown,
> that stuff in /etc/sysconfig/network-scripts, etc) do the right thing
> with this change?
> 

I havent seen issues so far.

> 	If memory serves, the initscripts will down the bond during
> setup; I'm not sure if there is any dependency on that action releasing
> all (possibly preexisting) slaves.
> 

The one i have experimented with has no issues - but you may be right
some people depend on this behavior at shutdown.

> 	I don't have a big problem with this, but I'm a little concerned
> that there may be dependencies on the existing behavior.

I could add a module parameter that restores old behavior when asked to
and we keep that for a while and have it print a warning message.
The other alternative is just release it and see if someone complains.

cheers,
jamal

Re: [RFC/PATCH][Bonding]: keep slave state when admin down

[jamal]

Jay,

I have tested with a standard bootup script - which amongst other things
brings down the bond and gives it a new MAC before bringing it up.

What do you wanna do with the patch? I know if it sits with me it will
be lost. 

cheers,
jamal

On Thu, 2006-20-07 at 16:22 -0400, jamal wrote:
> On Thu, 2006-20-07 at 11:50 -0700, Jay Vosburgh wrote:
> 
> > 
> > 	Do the initscript and sysconfig packages (/sbin/ifup, ifdown,
> > that stuff in /etc/sysconfig/network-scripts, etc) do the right thing
> > with this change?
> > 
> 
> I havent seen issues so far.
> 
> > 	If memory serves, the initscripts will down the bond during
> > setup; I'm not sure if there is any dependency on that action releasing
> > all (possibly preexisting) slaves.
> > 
> 
> The one i have experimented with has no issues - but you may be right
> some people depend on this behavior at shutdown.
> 
> > 	I don't have a big problem with this, but I'm a little concerned
> > that there may be dependencies on the existing behavior.
> 
> I could add a module parameter that restores old behavior when asked to
> and we keep that for a while and have it print a warning message.
> The other alternative is just release it and see if someone complains.
> 
> cheers,
> jamal