* [PATCH] d80211: use BUILD_BUG_ON
@ 2006-08-30 8:39 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2006-08-30 8:39 UTC (permalink / raw)
To: John W. Linville; +Cc: netdev, Jiri Benc, Jouni Malinen
This patch makes d80211 use BUILD_BUG_ON instead of checking at module
initialisation time. This check really is only interesting while you
hack since if the module was built, then it's either an 'always true' or
'always false' comparison, hence useless to do it at runtime.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
--- wireless-dev.orig/net/d80211/ieee80211.c 2006-08-25 17:53:16.488836518 +0200
+++ wireless-dev/net/d80211/ieee80211.c 2006-08-25 18:01:59.148836518 +0200
@@ -4833,13 +4833,8 @@ static int __init ieee80211_init(void)
struct sk_buff *skb;
int ret;
- if (sizeof(struct ieee80211_tx_packet_data) > (sizeof(skb->cb))) {
- printk("80211: ieee80211_tx_packet_data is bigger "
- "than the skb->cb (%d > %d)\n",
- (int) sizeof(struct ieee80211_tx_packet_data),
- (int) sizeof(skb->cb));
- return -EINVAL;
- }
+ BUILD_BUG_ON(sizeof(struct ieee80211_tx_packet_data) > sizeof(skb->cb));
+
if ((ret = ieee80211_sysfs_init())) {
printk(KERN_WARNING "ieee80211_init: sysfs initialization "
"failed\n");
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-08-30 8:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-30 8:39 [PATCH] d80211: use BUILD_BUG_ON Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox