From: Alexei Starovoitov <ast@fb.com>
To: Yonghong Song <yhs@fb.com>, <peterz@infradead.org>,
<rostedt@goodmis.org>, <daniel@iogearbox.net>, <kafai@fb.com>,
<netdev@vger.kernel.org>
Cc: <kernel-team@fb.com>
Subject: Re: [PATCH net-next 0/2] bpf/tracing: allow user space to query prog array on the same tp
Date: Wed, 29 Nov 2017 21:32:59 -0800 [thread overview]
Message-ID: <115a2167-9921-a45c-3877-a81953f9ddaf@fb.com> (raw)
In-Reply-To: <20171129072036.467246-1-yhs@fb.com>
On 11/28/17 11:20 PM, Yonghong Song wrote:
> Commit e87c6bc3852b ("bpf: permit multiple bpf attachments
> for a single perf event") added support to attach multiple
> bpf programs to a single perf event. Given a perf event
> (kprobe, uprobe, or kernel tracepoint), the perf ioctl interface
> is used to query bpf programs attached to the same trace event.
> The same ioctl interface is also used to attach bpf program.
> Patch #1 had the core implementation and patch #2 added
> a test case in tools bpf selftests suite.
We actually had an implementation of the same tracepoint+bpf
introspection via BPF_PROG_QUERY command that we use for cgroup+bpf,
but it looks cleaner to use ioctl() style of api here,
since attach to tracepoint/kuprobe is also done via ioctl.
For the set:
Acked-by: Alexei Starovoitov <ast@kernel.org>
The patch touches 3 lines in events/core.c but most likely
it won't conflict with anything in tip, so we plan to have
this set in bpf-next.git -> net-next.git only.
Thanks
prev parent reply other threads:[~2017-11-30 5:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 7:20 [PATCH net-next 0/2] bpf/tracing: allow user space to query prog array on the same tp Yonghong Song
2017-11-29 7:20 ` [PATCH net-next 1/2] " Yonghong Song
2017-11-30 17:27 ` Daniel Borkmann
2017-11-30 19:12 ` Yonghong Song
2017-11-29 7:20 ` [PATCH net-next 2/2] bpf/tracing: add a bpf test for new ioctl query interface Yonghong Song
2017-11-30 5:32 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=115a2167-9921-a45c-3877-a81953f9ddaf@fb.com \
--to=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox