From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
Larry Finger
<Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
Subject: Re: [PATCH] bcm43xx: Drain TX status before starting IRQs
Date: Fri, 20 Oct 2006 10:25:53 +1000 [thread overview]
Message-ID: <1161303953.10524.81.camel@localhost.localdomain> (raw)
In-Reply-To: <200610191729.35402.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
On Thu, 2006-10-19 at 17:29 +0200, Michael Buesch wrote:
> Drain the Microcode TX-status-FIFO before we enable IRQs.
> This is required, because the FIFO may still have entries left
> from a previous run. Those would immediately fire after enabling
> IRQs and would lead to an oops in the DMA TXstatus handling code.
>
> Signed-off-by: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
Great, thanks. Note that I haven't yet hit the bug since I updated the
firmware, so it could be a mix of firmware and that problem, though it's
not been long enough to be a clear results.
In any case, that patch should go in.
Cheers,
Ben.
next prev parent reply other threads:[~2006-10-20 0:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 15:29 [PATCH] bcm43xx: Drain TX status before starting IRQs Michael Buesch
[not found] ` <200610191729.35402.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2006-10-20 0:25 ` Benjamin Herrenschmidt [this message]
2006-11-02 5:46 ` Larry Finger
[not found] ` <45498633.7040808-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2006-11-02 8:45 ` Johannes Berg
2006-11-03 16:56 ` Jouni Malinen
[not found] ` <20061103165627.GC16894-T6t7IcXamKWaos4igUoMUw@public.gmane.org>
2006-11-04 16:38 ` Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2006-11-05 21:34 Larry Finger
2006-11-06 15:45 Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161303953.10524.81.camel@localhost.localdomain \
--to=benh-xvmvhmargas8u2djnn8i7kb+6bgklq7r@public.gmane.org \
--cc=Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org \
--cc=bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox