* [PATCH] b44: change comment about irq mask register
@ 2006-11-06 22:17 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2006-11-06 22:17 UTC (permalink / raw)
To: netdev; +Cc: zambrano
Through some experimentation with the similarly built bcm43xx I came to
the conclusion that if the hw/firmware sets a bit in the interrupt
register, an interrupt will only be raised if that bit is included in
the interrupt mask. Hence, the interrupt mask is more like an interrupt
control mask.
This patch changes the comment to reflect that.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
--- wireless-dev.orig/drivers/net/b44.c 2006-11-06 23:13:36.909597550 +0100
+++ wireless-dev/drivers/net/b44.c 2006-11-06 23:14:21.949597550 +0100
@@ -908,8 +908,9 @@ static irqreturn_t b44_interrupt(int irq
istat = br32(bp, B44_ISTAT);
imask = br32(bp, B44_IMASK);
- /* ??? What the fuck is the purpose of the interrupt mask
- * ??? register if we have to mask it out by hand anyways?
+ /* The interrupt mask register controls which interrupt bits
+ * will actually raise an interrupt to the CPU when set by hw/firmware,
+ * but doesn't mask off the bits.
*/
istat &= imask;
if (istat) {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-11-06 22:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-06 22:17 [PATCH] b44: change comment about irq mask register Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox