[PATCH] dt-bindings: Fix bracket

[PATCH] dt-bindings: Fix bracket

[Manuel Ebner]

Add "(Alternate" to "ID)"

Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
---
 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
index accff93d38f8..62bf982aff2b 100644
--- a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
+++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
@@ -33,7 +33,7 @@ properties:
           - usb424,9906   # SMSC9505A USB Ethernet Device (HAL)
           - usb424,9907   # SMSC9500 USB Ethernet Device (Alternate ID)
           - usb424,9908   # SMSC9500A USB Ethernet Device (Alternate ID)
-          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Device  ID)
+          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Device (Alternate ID)
           - usb424,9e00   # SMSC9500A USB Ethernet Device
           - usb424,9e01   # SMSC9505A USB Ethernet Device
           - usb424,9e08   # SMSC LAN89530 USB Ethernet Device
-- 
2.54.0

Re: [PATCH] dt-bindings: Fix bracket

[Krzysztof Kozlowski]

On Sat, Jun 27, 2026 at 11:19:36AM +0200, Manuel Ebner wrote:
> Add "(Alternate" to "ID)"

Why?

I see what you did in the diff, so why repeating it?

> 
> Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: Fix bracket

[Krzysztof Kozlowski]

On 29/06/2026 09:09, Krzysztof Kozlowski wrote:
> On Sat, Jun 27, 2026 at 11:19:36AM +0200, Manuel Ebner wrote:
>> Add "(Alternate" to "ID)"
> 
> Why?
> 
> I see what you did in the diff, so why repeating it?
> 

Heh, and the subject is "fix bracket" - what bracket?

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Best regards,
Krzysztof

RE: [PATCH] dt-bindings: Fix bracket

[Jagielski, Jedrzej]

From: Manuel Ebner <manuelebner@mailbox.org> 
Sent: Saturday, June 27, 2026 11:20 AM

>Add "(Alternate" to "ID)"
>
>Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>

Hi
as the title states that's fix path we also need a fixes tag
here in the commit msg pointing out which patch is being fixed

Re: [PATCH] dt-bindings: Fix bracket

[Manuel Ebner]

I'll admit I don't know exactly whats the issue

On Sat, 2026-06-27 at 11:19 +0200, Manuel Ebner wrote:
> Add "(Alternate" to "ID)"
> 
> Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
> ---
>  Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> index accff93d38f8..62bf982aff2b 100644
> --- a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> @@ -33,7 +33,7 @@ properties:
>            - usb424,9906   # SMSC9505A USB Ethernet Device (HAL)
>            - usb424,9907   # SMSC9500 USB Ethernet Device (Alternate ID)
>            - usb424,9908   # SMSC9500A USB Ethernet Device (Alternate ID)
> -          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Device  ID)

There's an issue in this line with the brace and maybe with the text as well.
I couldn't figure out what usb424,9909 is. Can somebody help me?
Below are some possible fixes.

> +          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Device
> +          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Device (Alternate ID)
> +          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Device (SAL10)

>            - usb424,9e00   # SMSC9500A USB Ethernet Device
>            - usb424,9e01   # SMSC9505A USB Ethernet Device
>            - usb424,9e08   # SMSC LAN89530 USB Ethernet Device

Thanks
 Manuel