Netdev List
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, TAKANO Ryousei <takano@axe-inc.co.jp>
Subject: [PATCH 2/7] [TCP]: Fix mark_head_lost to ignore R-bit when trying to mark L
Date: Thu, 11 Oct 2007 14:41:02 +0300	[thread overview]
Message-ID: <1192102867725-git-send-email-ilpo.jarvinen@helsinki.fi> (raw)
In-Reply-To: <11921028673599-git-send-email-ilpo.jarvinen@helsinki.fi>

This condition (plain R) can arise at least in recovery that
is triggered after tcp_undo_loss. There isn't any reason why
they should not be marked as lost, not marking makes in_flight
estimator to return too large values.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---
 net/ipv4/tcp_input.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index e40857e..c827285 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -1987,7 +1987,7 @@ static void tcp_mark_head_lost(struct sock *sk,
 		cnt += tcp_skb_pcount(skb);
 		if (cnt > packets || after(TCP_SKB_CB(skb)->end_seq, high_seq))
 			break;
-		if (!(TCP_SKB_CB(skb)->sacked&TCPCB_TAGBITS)) {
+		if (!(TCP_SKB_CB(skb)->sacked & (TCPCB_SACKED_ACKED|TCPCB_LOST))) {
 			TCP_SKB_CB(skb)->sacked |= TCPCB_LOST;
 			tp->lost_out += tcp_skb_pcount(skb);
 			tcp_verify_retransmit_hint(tp, skb);
-- 
1.5.0.6


  reply	other threads:[~2007-10-11 11:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-11 11:41 [PATCH net-2.6 0/7] TCP: small changes/fixes + lost_retrans brokeness fix Ilpo Järvinen
2007-10-11 11:41 ` [PATCH 1/7] [TCP]: Add bytes_acked (ABC) clearing to FRTO too Ilpo Järvinen
2007-10-11 11:41   ` Ilpo Järvinen [this message]
2007-10-11 11:41     ` [PATCH 3/7] [TCP]: Kill almost unused variable pcount from sacktag Ilpo Järvinen
2007-10-11 11:41       ` [PATCH 4/7] [TCP]: Extract tcp_match_queue_to_sack from sacktag code Ilpo Järvinen
2007-10-11 11:41         ` [PATCH 5/7] [TCP]: No need to re-count fackets_out/sacked_out at RTO Ilpo Järvinen
2007-10-11 11:41           ` [PATCH 6/7] [TCP]: Fix lost_retrans loop vs fastpath problems Ilpo Järvinen
2007-10-11 11:41             ` [PATCH 7/7] [TCP]: Limit processing lost_retrans loop to work-to-do cases Ilpo Järvinen
2007-10-12  0:36               ` David Miller
2007-10-18  3:50                 ` TAKANO Ryousei
2007-10-18  9:40                   ` [PATCH] [TCP]: Add highest_sack_end_seq check back to lost_retrans call Ilpo Järvinen
2007-10-18 10:17                     ` [PATCH] [TCP]: Remove lost_retrans zero special cases Ilpo Järvinen
2007-10-18 10:55                       ` TAKANO Ryousei
2007-10-18 11:07                         ` Ilpo Järvinen
2007-10-18 12:08                           ` David Miller
2007-10-12  0:35             ` [PATCH 6/7] [TCP]: Fix lost_retrans loop vs fastpath problems David Miller
2007-10-12  0:35           ` [PATCH 5/7] [TCP]: No need to re-count fackets_out/sacked_out at RTO David Miller
2007-10-12  0:34         ` [PATCH 4/7] [TCP]: Extract tcp_match_queue_to_sack from sacktag code David Miller
2007-10-12  0:34       ` [PATCH 3/7] [TCP]: Kill almost unused variable pcount from sacktag David Miller
2007-10-12  0:33     ` [PATCH 2/7] [TCP]: Fix mark_head_lost to ignore R-bit when trying to mark L David Miller
2007-10-12  0:32   ` [PATCH 1/7] [TCP]: Add bytes_acked (ABC) clearing to FRTO too David Miller
2007-10-12  0:37 ` [PATCH net-2.6 0/7] TCP: small changes/fixes + lost_retrans brokeness fix David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1192102867725-git-send-email-ilpo.jarvinen@helsinki.fi \
    --to=ilpo.jarvinen@helsinki.fi \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=takano@axe-inc.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox