From: TAKANO Ryousei <takano@axe-inc.co.jp>
To: davem@davemloft.net
Cc: ilpo.jarvinen@helsinki.fi, y-kodama@aist.go.jp, netdev@vger.kernel.org
Subject: Re: [PATCH 7/7] [TCP]: Limit processing lost_retrans loop to work-to-do cases
Date: Thu, 18 Oct 2007 12:50:45 +0900 (JST) [thread overview]
Message-ID: <20071018.125045.90803775.takano@axe-inc.co.jp> (raw)
In-Reply-To: <20071011.173622.09942622.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH 7/7] [TCP]: Limit processing lost_retrans loop to work-to-do cases
Date: Thu, 11 Oct 2007 17:36:22 -0700 (PDT)
> From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
> Date: Thu, 11 Oct 2007 14:41:07 +0300
>
> > This addition of lost_retrans_low to tcp_sock might be
> > unnecessary, it's not clear how often lost_retrans worker is
> > executed when there wasn't work to do.
> >
> > Cc: TAKANO Ryousei <takano@axe-inc.co.jp>
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
>
> Applied.
> + after(highest_sack_end_seq, tp->lost_retrans_low) &&
This limit degrades the performance of my test case described before,
since it misses opportunities of detecting loss of retransmitted packets.
The results are shown as follows:
linux-2.6.23
iteration :001 .... done. T = 19.758205 BW = 404.895077 Mbps
iteration :002 .... done. T = 19.241735 BW = 415.762924 Mbps
iteration :003 .... done. T = 18.998427 BW = 421.087495 Mbps
iteration :004 .... done. T = 18.971502 BW = 421.685113 Mbps
iteration :005 .... done. T = 19.298313 BW = 414.544009 Mbps
net-2.6 (current):
iteration :001 .... done. T = 43.672971 BW = 183.179660 Mbps
iteration :002 .... done. T = 16.668652 BW = 479.942828 Mbps
iteration :003 .... done. T = 25.569106 BW = 312.877581 Mbps
iteration :004 .... done. T = 55.314832 BW = 144.626671 Mbps
iteration :005 .... done. T = 35.377025 BW = 226.135464 Mbps
net-2.6 (no limit)
iteration :001 .... done. T = 16.907727 BW = 473.156445 Mbps
iteration :002 .... done. T = 16.662908 BW = 480.108272 Mbps
iteration :003 .... done. T = 16.536396 BW = 483.781350 Mbps
iteration :004 .... done. T = 16.565220 BW = 482.939560 Mbps
iteration :005 .... done. T = 16.528676 BW = 484.007309 Mbps
"no limit" does as follows:
if (tp->retrans_out && highest_sack_end_seq &&
icsk->icsk_ca_state == TCP_CA_Recovery)
flag |= tcp_mark_lost_retrans(sk, highest_sack_end_seq);
Ryousei Takano
next prev parent reply other threads:[~2007-10-18 3:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 11:41 [PATCH net-2.6 0/7] TCP: small changes/fixes + lost_retrans brokeness fix Ilpo Järvinen
2007-10-11 11:41 ` [PATCH 1/7] [TCP]: Add bytes_acked (ABC) clearing to FRTO too Ilpo Järvinen
2007-10-11 11:41 ` [PATCH 2/7] [TCP]: Fix mark_head_lost to ignore R-bit when trying to mark L Ilpo Järvinen
2007-10-11 11:41 ` [PATCH 3/7] [TCP]: Kill almost unused variable pcount from sacktag Ilpo Järvinen
2007-10-11 11:41 ` [PATCH 4/7] [TCP]: Extract tcp_match_queue_to_sack from sacktag code Ilpo Järvinen
2007-10-11 11:41 ` [PATCH 5/7] [TCP]: No need to re-count fackets_out/sacked_out at RTO Ilpo Järvinen
2007-10-11 11:41 ` [PATCH 6/7] [TCP]: Fix lost_retrans loop vs fastpath problems Ilpo Järvinen
2007-10-11 11:41 ` [PATCH 7/7] [TCP]: Limit processing lost_retrans loop to work-to-do cases Ilpo Järvinen
2007-10-12 0:36 ` David Miller
2007-10-18 3:50 ` TAKANO Ryousei [this message]
2007-10-18 9:40 ` [PATCH] [TCP]: Add highest_sack_end_seq check back to lost_retrans call Ilpo Järvinen
2007-10-18 10:17 ` [PATCH] [TCP]: Remove lost_retrans zero special cases Ilpo Järvinen
2007-10-18 10:55 ` TAKANO Ryousei
2007-10-18 11:07 ` Ilpo Järvinen
2007-10-18 12:08 ` David Miller
2007-10-12 0:35 ` [PATCH 6/7] [TCP]: Fix lost_retrans loop vs fastpath problems David Miller
2007-10-12 0:35 ` [PATCH 5/7] [TCP]: No need to re-count fackets_out/sacked_out at RTO David Miller
2007-10-12 0:34 ` [PATCH 4/7] [TCP]: Extract tcp_match_queue_to_sack from sacktag code David Miller
2007-10-12 0:34 ` [PATCH 3/7] [TCP]: Kill almost unused variable pcount from sacktag David Miller
2007-10-12 0:33 ` [PATCH 2/7] [TCP]: Fix mark_head_lost to ignore R-bit when trying to mark L David Miller
2007-10-12 0:32 ` [PATCH 1/7] [TCP]: Add bytes_acked (ABC) clearing to FRTO too David Miller
2007-10-12 0:37 ` [PATCH net-2.6 0/7] TCP: small changes/fixes + lost_retrans brokeness fix David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071018.125045.90803775.takano@axe-inc.co.jp \
--to=takano@axe-inc.co.jp \
--cc=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
--cc=y-kodama@aist.go.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox