[PATCH 7/7] [NETDEV]: myri10ge Fix possible causing oops of net_rx_action

[PATCH 7/7] [NETDEV]: myri10ge Fix possible causing oops of net_rx_action

[Joonwoo Park]

[NETDEV]: myri10ge Fix possible causing oops of net_rx_action

Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
---
 drivers/net/myri10ge/myri10ge.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index 8def865..57311ed 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -1242,6 +1242,8 @@ static int myri10ge_poll(struct napi_struct *napi, int budget)
 	if (work_done < budget || !netif_running(netdev)) {
 		netif_rx_complete(netdev, napi);
 		put_be32(htonl(3), mgp->irq_claim);
+		if (unlikely(work_done == napi->weight))
+			return work_done - 1;
 	}
 	return work_done;
 }
---

Re: [PATCH 7/7] : myri10ge Fix possible causing oops of net_rx_action

[Subrata Modak]

Would you like to submit the Driver Test Cases to LTP ? Or, if you have
your Driver test cases written in C, we can port to LTP and have it
inside the LTP package.
You can also check out the following links for more info, and can always
ping me for anything:
http://ltp.cvs.sourceforge.net/ltp/ltp/testcases/kernel/device-drivers/,
http://ltp.sourceforge.net/documentation/how-to/ltp.php?

Regards--
Subrata
(LTP Maintainer)

On Wed, 2007-12-12 at 13:01 +0900, Joonwoo Park wrote:
> [NETDEV]: myri10ge Fix possible causing oops of net_rx_action
> 
> Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
> ---
>  drivers/net/myri10ge/myri10ge.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
> index 8def865..57311ed 100644
> --- a/drivers/net/myri10ge/myri10ge.c
> +++ b/drivers/net/myri10ge/myri10ge.c
> @@ -1242,6 +1242,8 @@ static int myri10ge_poll(struct napi_struct *napi, int budget)
>  	if (work_done < budget || !netif_running(netdev)) {
>  		netif_rx_complete(netdev, napi);
>  		put_be32(htonl(3), mgp->irq_claim);
> +		if (unlikely(work_done == napi->weight))
> +			return work_done - 1;
>  	}
>  	return work_done;
>  }
> ---
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 7/7] : myri10ge Fix possible causing oops of net_rx_action

[Joonwoo Park]

2007/12/12, Subrata Modak <subrata@linux.vnet.ibm.com>:
> Would you like to submit the Driver Test Cases to LTP ? Or, if you have
> your Driver test cases written in C, we can port to LTP and have it
> inside the LTP package.
> You can also check out the following links for more info, and can always
> ping me for anything:
> http://ltp.cvs.sourceforge.net/ltp/ltp/testcases/kernel/device-drivers/,
> http://ltp.sourceforge.net/documentation/how-to/ltp.php?
>
> Regards--
> Subrata
> (LTP Maintainer)
>

Subrata,
I can't sure it's possible since my test was needed some hardware
stuffs but I'll try it in near future and contact you.

Thanks.
Joonwoo