From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Ron Rindjunsky
<ron.rindjunsky-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: handing cloned frames to netif_rx()?
Date: Fri, 11 Jan 2008 02:17:26 +0100 [thread overview]
Message-ID: <1200014246.3861.148.camel@johannes.berg> (raw)
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
In 802.11n, there is a case where multiple data frames are received
aggregated into a single frame (A-MSDU).
Currently, we copy each of these frames out into their own skb, but
because of the alignment with that etc. I started to think that we could
simply pass up a clone of the original skb with start/length adjusted
properly so that it windows only the contained packet.
The buffer would be shared but the data within the original window
(starting with the 802.3 header) could even be written to, it won't be
needed again by mac80211 once it's handed off to netif_rx(). The skb
will obviously have lots of head- and tailroom but that space would be
part of other packets.
Is it ok to do this? Will something freak out if we pass a cloned skb to
netif_rx()?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next reply other threads:[~2008-01-11 1:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 1:17 Johannes Berg [this message]
[not found] ` <1200014246.3861.148.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-01-11 22:31 ` handing cloned frames to netif_rx()? Herbert Xu
2008-01-11 22:58 ` Johannes Berg
[not found] ` <1200092285.3528.5.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-01-11 23:01 ` Herbert Xu
[not found] ` <20080111230105.GA32656-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2008-01-11 23:04 ` Johannes Berg
2008-01-11 22:48 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200014246.3861.148.camel@johannes.berg \
--to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ron.rindjunsky-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox