From: Johannes Berg <johannes@sipsolutions.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org, ron.rindjunsky@intel.com,
linux-wireless@vger.kernel.org
Subject: Re: handing cloned frames to netif_rx()?
Date: Fri, 11 Jan 2008 23:58:05 +0100 [thread overview]
Message-ID: <1200092285.3528.5.camel@johannes.berg> (raw)
In-Reply-To: <E1JDSPG-0008Of-00@gondolin.me.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On Sat, 2008-01-12 at 09:31 +1100, Herbert Xu wrote:
> Johannes Berg <johannes@sipsolutions.net> wrote:
> >
> > Is it ok to do this? Will something freak out if we pass a cloned skb to
> > netif_rx()?
>
> Sounds OK as long as you stick to the rules of cloned skb's, e.g., not
> writing to them unless you've copied it.
Ok. Yes, we will of course adhere to that, but I was wondering whether
maybe the net stack assumes somewhere that a packet it got from the
driver can be written to w/o copying.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2008-01-11 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 1:17 handing cloned frames to netif_rx()? Johannes Berg
[not found] ` <1200014246.3861.148.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-01-11 22:31 ` Herbert Xu
2008-01-11 22:58 ` Johannes Berg [this message]
[not found] ` <1200092285.3528.5.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-01-11 23:01 ` Herbert Xu
[not found] ` <20080111230105.GA32656-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2008-01-11 23:04 ` Johannes Berg
2008-01-11 22:48 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200092285.3528.5.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ron.rindjunsky@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox