Netdev List
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: netdev <netdev@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ieee80211: fix section mismatch warning
Date: Fri, 01 Feb 2008 13:07:12 +0100	[thread overview]
Message-ID: <1201867632.4188.0.camel@johannes.berg> (raw)
In-Reply-To: <20080201115206.GA12678@uranus.ravnborg.org> (sfid-20080201_125234_351197_7981BA3B)

[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]


On Fri, 2008-02-01 at 12:52 +0100, Sam Ravnborg wrote:
> Fix the following warnings:
> WARNING: net/built-in.o(.init.text+0xd6c0): Section mismatch in reference from the function ieee80211_init() to the function .exit.text:rc80211_simple_exit()
> WARNING: net/built-in.o(.init.text+0xd6c5): Section mismatch in reference from the function ieee80211_init() to the function .exit.text:rc80211_pid_exit()
> 
> The fix was simple - I just did as modpost told me and removed the
> wrong __exit annotation of rc80211_simple_exit and rc80211_pid_exit.

Heh, I just sent the same patch.

> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: John W. Linville <linville@tuxdriver.com>
> Cc: David S. Miller <davem@davemloft.net>
> ---
> 
> With this patch my allyesconfig build on x86 (64 bit)
> is section mismatch clean in net/
> 
> 	Sam
> 
> diff --git a/net/mac80211/rc80211_pid_algo.c b/net/mac80211/rc80211_pid_algo.c
> index 554c4ba..c339571 100644
> --- a/net/mac80211/rc80211_pid_algo.c
> +++ b/net/mac80211/rc80211_pid_algo.c
> @@ -538,7 +538,7 @@ int __init rc80211_pid_init(void)
>  	return ieee80211_rate_control_register(&mac80211_rcpid);
>  }
>  
> -void __exit rc80211_pid_exit(void)
> +void rc80211_pid_exit(void)
>  {
>  	ieee80211_rate_control_unregister(&mac80211_rcpid);
>  }
> diff --git a/net/mac80211/rc80211_simple.c b/net/mac80211/rc80211_simple.c
> index 934676d..9a78b11 100644
> --- a/net/mac80211/rc80211_simple.c
> +++ b/net/mac80211/rc80211_simple.c
> @@ -389,7 +389,7 @@ int __init rc80211_simple_init(void)
>  	return ieee80211_rate_control_register(&mac80211_rcsimple);
>  }
>  
> -void __exit rc80211_simple_exit(void)
> +void rc80211_simple_exit(void)
>  {
>  	ieee80211_rate_control_unregister(&mac80211_rcsimple);
>  }
> 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2008-02-01 12:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01 11:52 [PATCH] ieee80211: fix section mismatch warning Sam Ravnborg
2008-02-01 12:07 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201867632.4188.0.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox