Netdev List
 help / color / mirror / Atom feed
* [PATCH] ieee80211: fix section mismatch warning
@ 2008-02-01 11:52 Sam Ravnborg
  2008-02-01 12:07 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Sam Ravnborg @ 2008-02-01 11:52 UTC (permalink / raw)
  To: netdev, Johannes Berg, John W. Linville, David S. Miller

Fix the following warnings:
WARNING: net/built-in.o(.init.text+0xd6c0): Section mismatch in reference from the function ieee80211_init() to the function .exit.text:rc80211_simple_exit()
WARNING: net/built-in.o(.init.text+0xd6c5): Section mismatch in reference from the function ieee80211_init() to the function .exit.text:rc80211_pid_exit()

The fix was simple - I just did as modpost told me and removed the
wrong __exit annotation of rc80211_simple_exit and rc80211_pid_exit.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: John W. Linville <linville@tuxdriver.com>
Cc: David S. Miller <davem@davemloft.net>
---

With this patch my allyesconfig build on x86 (64 bit)
is section mismatch clean in net/

	Sam

diff --git a/net/mac80211/rc80211_pid_algo.c b/net/mac80211/rc80211_pid_algo.c
index 554c4ba..c339571 100644
--- a/net/mac80211/rc80211_pid_algo.c
+++ b/net/mac80211/rc80211_pid_algo.c
@@ -538,7 +538,7 @@ int __init rc80211_pid_init(void)
 	return ieee80211_rate_control_register(&mac80211_rcpid);
 }
 
-void __exit rc80211_pid_exit(void)
+void rc80211_pid_exit(void)
 {
 	ieee80211_rate_control_unregister(&mac80211_rcpid);
 }
diff --git a/net/mac80211/rc80211_simple.c b/net/mac80211/rc80211_simple.c
index 934676d..9a78b11 100644
--- a/net/mac80211/rc80211_simple.c
+++ b/net/mac80211/rc80211_simple.c
@@ -389,7 +389,7 @@ int __init rc80211_simple_init(void)
 	return ieee80211_rate_control_register(&mac80211_rcsimple);
 }
 
-void __exit rc80211_simple_exit(void)
+void rc80211_simple_exit(void)
 {
 	ieee80211_rate_control_unregister(&mac80211_rcsimple);
 }

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ieee80211: fix section mismatch warning
  2008-02-01 11:52 [PATCH] ieee80211: fix section mismatch warning Sam Ravnborg
@ 2008-02-01 12:07 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2008-02-01 12:07 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: netdev, John W. Linville, David S. Miller, linux-wireless

[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]


On Fri, 2008-02-01 at 12:52 +0100, Sam Ravnborg wrote:
> Fix the following warnings:
> WARNING: net/built-in.o(.init.text+0xd6c0): Section mismatch in reference from the function ieee80211_init() to the function .exit.text:rc80211_simple_exit()
> WARNING: net/built-in.o(.init.text+0xd6c5): Section mismatch in reference from the function ieee80211_init() to the function .exit.text:rc80211_pid_exit()
> 
> The fix was simple - I just did as modpost told me and removed the
> wrong __exit annotation of rc80211_simple_exit and rc80211_pid_exit.

Heh, I just sent the same patch.

> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: John W. Linville <linville@tuxdriver.com>
> Cc: David S. Miller <davem@davemloft.net>
> ---
> 
> With this patch my allyesconfig build on x86 (64 bit)
> is section mismatch clean in net/
> 
> 	Sam
> 
> diff --git a/net/mac80211/rc80211_pid_algo.c b/net/mac80211/rc80211_pid_algo.c
> index 554c4ba..c339571 100644
> --- a/net/mac80211/rc80211_pid_algo.c
> +++ b/net/mac80211/rc80211_pid_algo.c
> @@ -538,7 +538,7 @@ int __init rc80211_pid_init(void)
>  	return ieee80211_rate_control_register(&mac80211_rcpid);
>  }
>  
> -void __exit rc80211_pid_exit(void)
> +void rc80211_pid_exit(void)
>  {
>  	ieee80211_rate_control_unregister(&mac80211_rcpid);
>  }
> diff --git a/net/mac80211/rc80211_simple.c b/net/mac80211/rc80211_simple.c
> index 934676d..9a78b11 100644
> --- a/net/mac80211/rc80211_simple.c
> +++ b/net/mac80211/rc80211_simple.c
> @@ -389,7 +389,7 @@ int __init rc80211_simple_init(void)
>  	return ieee80211_rate_control_register(&mac80211_rcsimple);
>  }
>  
> -void __exit rc80211_simple_exit(void)
> +void rc80211_simple_exit(void)
>  {
>  	ieee80211_rate_control_unregister(&mac80211_rcsimple);
>  }
> 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-01 12:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-01 11:52 [PATCH] ieee80211: fix section mismatch warning Sam Ravnborg
2008-02-01 12:07 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox