public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: netdev@vger.kernel.org, isdn4linux@listserv.isdn4linux.de
Cc: Jeff Garzik <jgarzik@redhat.com>
Subject: [PATCH] [NET] [ISDN]: Do not validate ISDN net device address prior to interface-up
Date: Thu, 10 Apr 2008 17:00:17 +0200	[thread overview]
Message-ID: <1207839617.4311.6.camel@compaq.thuisdomein> (raw)

From: Paul Bolle <pebolle@tiscali.nl>
   
Commit bada339 (Validate device addr prior to interface-up) caused a regression
in the ISDN network code, see: http://bugzilla.kernel.org/show_bug.cgi?id=9923
The trivial fix is to remove the pointer to eth_validate_addr() in the
net_device struct in isdn_net_init().
    
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Please note that I hardly know what the device address validation is good for.
Neither do I know much about the ISDN network code or why the device address
validation fails for ISDN interfaces. This patch however basically reverts 
commit bada339 just for the ISDN network code. I can't think of any side
effects.

http://bugzilla.kernel.org/show_bug.cgi?id=9923 would have been much easier to
track down if eth_validate_addr() would somehow complain aloud if an address 
is invalid. Shouldn't it make at least some noise?

diff --git a/drivers/isdn/i4l/isdn_net.c b/drivers/isdn/i4l/isdn_net.c
index ced83c2..ef1a300 100644
--- a/drivers/isdn/i4l/isdn_net.c
+++ b/drivers/isdn/i4l/isdn_net.c
@@ -2010,6 +2010,7 @@ isdn_net_init(struct net_device *ndev)
 	ndev->flags = IFF_NOARP|IFF_POINTOPOINT;
 	ndev->type = ARPHRD_ETHER;
 	ndev->addr_len = ETH_ALEN;
+	ndev->validate_addr = NULL;
 
 	/* for clients with MPPP maybe higher values better */
 	ndev->tx_queue_len = 30;


             reply	other threads:[~2008-04-10 15:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-10 15:00 Paul Bolle [this message]
2008-04-13  6:29 ` [PATCH] [NET] [ISDN]: Do not validate ISDN net device address prior to interface-up Patrick McHardy
2008-04-13  8:06   ` Jarek Poplawski
2008-04-13  8:05     ` Patrick McHardy
2008-04-13  8:27       ` Jarek Poplawski
2008-04-13  8:26         ` Patrick McHardy
2008-04-13  8:51           ` Jarek Poplawski
2008-04-14  5:46   ` David Miller
2008-04-14  5:44 ` David Miller
2008-04-14  6:01   ` Jarek Poplawski
2008-04-14  5:57     ` Patrick McHardy
2008-04-14  6:07       ` Jarek Poplawski
2008-04-14  6:32       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207839617.4311.6.camel@compaq.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=isdn4linux@listserv.isdn4linux.de \
    --cc=jgarzik@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox