public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: [PATCH/RFC] deprecate print_mac
Date: Sat, 25 Oct 2008 02:09:55 +0200	[thread overview]
Message-ID: <1224893395.3919.39.camel@johannes.berg> (raw)

Or more precisely, deprecate the variables that DECLARE_MAC_BUF
creates, DECLARE_MAC_BUF is required for print_mac and the latter
uses the created variables.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
I don't think we want this without the bulk of the users removed. And
after that, it should be removed before long anyway.

 include/linux/if_ether.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- everything.orig/include/linux/if_ether.h	2008-10-25 02:02:02.000000000 +0200
+++ everything/include/linux/if_ether.h	2008-10-25 02:05:08.000000000 +0200
@@ -133,12 +133,12 @@ extern struct ctl_table ether_table[];
 extern ssize_t sysfs_format_mac(char *buf, const unsigned char *addr, int len);
 
 /*
- *	Display a 6 byte device address (MAC) in a readable format.
+ * Use the %pM printf format specifier instead of this.
  */
 extern char *print_mac(char *buf, const unsigned char *addr);
 #define MAC_FMT "%02x:%02x:%02x:%02x:%02x:%02x"
 #define MAC_BUF_SIZE	18
-#define DECLARE_MAC_BUF(var) char var[MAC_BUF_SIZE] __maybe_unused
+#define DECLARE_MAC_BUF(var) char var[MAC_BUF_SIZE] __maybe_unused __deprecated
 
 #endif
 



             reply	other threads:[~2008-10-25  0:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-25  0:09 Johannes Berg [this message]
2008-10-27 22:49 ` [PATCH/RFC] deprecate print_mac David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224893395.3919.39.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox