[PATCH/RFC] deprecate print_mac

[PATCH/RFC] deprecate print_mac

[Johannes Berg]

Or more precisely, deprecate the variables that DECLARE_MAC_BUF
creates, DECLARE_MAC_BUF is required for print_mac and the latter
uses the created variables.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
I don't think we want this without the bulk of the users removed. And
after that, it should be removed before long anyway.

 include/linux/if_ether.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- everything.orig/include/linux/if_ether.h	2008-10-25 02:02:02.000000000 +0200
+++ everything/include/linux/if_ether.h	2008-10-25 02:05:08.000000000 +0200
@@ -133,12 +133,12 @@ extern struct ctl_table ether_table[];
 extern ssize_t sysfs_format_mac(char *buf, const unsigned char *addr, int len);
 
 /*
- *	Display a 6 byte device address (MAC) in a readable format.
+ * Use the %pM printf format specifier instead of this.
  */
 extern char *print_mac(char *buf, const unsigned char *addr);
 #define MAC_FMT "%02x:%02x:%02x:%02x:%02x:%02x"
 #define MAC_BUF_SIZE	18
-#define DECLARE_MAC_BUF(var) char var[MAC_BUF_SIZE] __maybe_unused
+#define DECLARE_MAC_BUF(var) char var[MAC_BUF_SIZE] __maybe_unused __deprecated
 
 #endif
 

Re: [PATCH/RFC] deprecate print_mac

[David Miller]

From: Johannes Berg <johannes@sipsolutions.net>
Date: Sat, 25 Oct 2008 02:09:55 +0200

> Or more precisely, deprecate the variables that DECLARE_MAC_BUF
> creates, DECLARE_MAC_BUF is required for print_mac and the latter
> uses the created variables.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> I don't think we want this without the bulk of the users removed. And
> after that, it should be removed before long anyway.

I've decided not to apply this one.  Anyone who wants to help get rid
of this can run grep, otherwise it's just compile noise that doesn't
really help but does annoy. :-)