Re: rtnetlink: propagate error from dev_change_flags in do_setlink()

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

On Sun, 2008-11-16 at 14:10 +0100, Johannes Berg wrote:
> Unlike ifconfig, iproute doesn't report an error when setting
> an interface up fails:
> 
> (example: put wireless network mac80211 interface into repeater mode
> with iwconfig but do not set a peer MAC address, it should fail with
> -ENOLINK)
> 
> without patch:
> # ip link set wlan0 up ; echo $?
> 0
> # 
> 
> with patch:
> # ip link set wlan0 up ; echo $?
> RTNETLINK answers: Link has been severed
> 2
> # 
> 
> Propagate the return value from dev_change_flags() to fix this.
> 
> Signed-off-by: Patrick McHardy <kaber@trash.net>
> Tested-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

Maybe add
Cc: stable@kernel.org [since the beginning of time^Wgit]

when committing? Not sure it's appropriate for stable since so far
nobody complained, I suspect people just use the ioctl anyway.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]