Re: rtnetlink: propagate error from dev_change_flags in do_setlink()

[David Miller <davem@davemloft.net>]

From: Johannes Berg <johannes@sipsolutions.net>
Date: Sun, 16 Nov 2008 14:16:08 +0100

> On Sun, 2008-11-16 at 14:10 +0100, Johannes Berg wrote:
> > Unlike ifconfig, iproute doesn't report an error when setting
> > an interface up fails:
> > 
> > (example: put wireless network mac80211 interface into repeater mode
> > with iwconfig but do not set a peer MAC address, it should fail with
> > -ENOLINK)
> > 
> > without patch:
> > # ip link set wlan0 up ; echo $?
> > 0
> > # 
> > 
> > with patch:
> > # ip link set wlan0 up ; echo $?
> > RTNETLINK answers: Link has been severed
> > 2
> > # 
> > 
> > Propagate the return value from dev_change_flags() to fix this.
> > 
> > Signed-off-by: Patrick McHardy <kaber@trash.net>
> > Tested-by: Johannes Berg <johannes@sipsolutions.net>
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

Patch applied.

> Maybe add
> Cc: stable@kernel.org [since the beginning of time^Wgit]
> 
> when committing? Not sure it's appropriate for stable since so far
> nobody complained, I suspect people just use the ioctl anyway.

I'll queue it up for -stable, thanks.