From: David Hollis <dhollis@davehollis.com>
To: Pantelis Koukousoulas <pktoss@gmail.com>
Cc: netdev@vger.kernel.org, Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH] Fix asix-based gigabit cards connecting to 10 or 100Mbs networks
Date: Wed, 19 Nov 2008 13:23:37 -0500 [thread overview]
Message-ID: <1227119017.4419.268.camel@dhollis-lnx> (raw)
In-Reply-To: <1295ed070811171041j1258ec41kc6b1db61e83b628e@mail.gmail.com>
On Mon, 2008-11-17 at 20:41 +0200, Pantelis Koukousoulas wrote:
> Add AX_MEDIUM_ENCK also when speed = 10/100Mbps. This allows my belkin
> f5d5055 to work with my 100Mbps switch and with an old 10Mbps ISA card.
> Without this patch, the card is recognized and the interface is brought
> up fine, but no packets actually flow through the interface.
>
Please apply.
Thanks.
> Signed-off-by: Pantelis Koukousoulas <pktoss@gmail.com>
> Acked-by: David Hollis <dhollis@davehollis.com>
>
> Index: linux-next/drivers/net/usb/
> asix.c
> ===================================================================
> --- linux-next.orig/drivers/net/usb/asix.c 2008-11-04
> 19:51:06.000000000 +0200
> +++ linux-next/drivers/net/usb/asix.c 2008-11-04 21:32:55.000000000 +0200
> @@ -1102,12 +1102,14 @@
> mode = AX88178_MEDIUM_DEFAULT;
>
> if (ecmd.speed == SPEED_1000)
> - mode |= AX_MEDIUM_GM | AX_MEDIUM_ENCK;
> + mode |= AX_MEDIUM_GM;
> else if (ecmd.speed == SPEED_100)
> mode |= AX_MEDIUM_PS;
> else
> mode &= ~(AX_MEDIUM_PS | AX_MEDIUM_GM);
>
> + mode |= AX_MEDIUM_ENCK;
> +
> if (ecmd.duplex == DUPLEX_FULL)
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-11-19 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 18:41 [PATCH] Fix asix-based gigabit cards connecting to 10 or 100Mbs networks Pantelis Koukousoulas
2008-11-19 18:23 ` David Hollis [this message]
2008-11-20 8:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227119017.4419.268.camel@dhollis-lnx \
--to=dhollis@davehollis.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=pktoss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox