public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix asix-based gigabit cards connecting to 10 or 100Mbs networks
@ 2008-11-17 18:41 Pantelis Koukousoulas
  2008-11-19 18:23 ` David Hollis
  2008-11-20  8:29 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Pantelis Koukousoulas @ 2008-11-17 18:41 UTC (permalink / raw)
  To: netdev

Add AX_MEDIUM_ENCK also when speed = 10/100Mbps. This allows my belkin
 f5d5055 to work with my 100Mbps switch and with an old 10Mbps ISA card.
 Without this patch, the card is recognized and the interface is brought
 up fine, but no packets actually flow through the interface.

 Signed-off-by: Pantelis Koukousoulas <pktoss@gmail.com>
 Acked-by: David Hollis <dhollis@davehollis.com>

 Index: linux-next/drivers/net/usb/
 asix.c
 ===================================================================
 --- linux-next.orig/drivers/net/usb/asix.c      2008-11-04
 19:51:06.000000000 +0200
 +++ linux-next/drivers/net/usb/asix.c   2008-11-04 21:32:55.000000000 +0200
 @@ -1102,12 +1102,14 @@
        mode = AX88178_MEDIUM_DEFAULT;

        if (ecmd.speed == SPEED_1000)
 -               mode |= AX_MEDIUM_GM | AX_MEDIUM_ENCK;
 +               mode |= AX_MEDIUM_GM;
        else if (ecmd.speed == SPEED_100)
                mode |= AX_MEDIUM_PS;
        else
                mode &= ~(AX_MEDIUM_PS | AX_MEDIUM_GM);

 +       mode |= AX_MEDIUM_ENCK;
 +
        if (ecmd.duplex == DUPLEX_FULL)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix asix-based gigabit cards connecting to 10 or 100Mbs networks
  2008-11-17 18:41 [PATCH] Fix asix-based gigabit cards connecting to 10 or 100Mbs networks Pantelis Koukousoulas
@ 2008-11-19 18:23 ` David Hollis
  2008-11-20  8:29 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Hollis @ 2008-11-19 18:23 UTC (permalink / raw)
  To: Pantelis Koukousoulas; +Cc: netdev, Jeff Garzik

On Mon, 2008-11-17 at 20:41 +0200, Pantelis Koukousoulas wrote:
> Add AX_MEDIUM_ENCK also when speed = 10/100Mbps. This allows my belkin
>  f5d5055 to work with my 100Mbps switch and with an old 10Mbps ISA card.
>  Without this patch, the card is recognized and the interface is brought
>  up fine, but no packets actually flow through the interface.
> 

Please apply.

Thanks.

>  Signed-off-by: Pantelis Koukousoulas <pktoss@gmail.com>
>  Acked-by: David Hollis <dhollis@davehollis.com>
> 
>  Index: linux-next/drivers/net/usb/
>  asix.c
>  ===================================================================
>  --- linux-next.orig/drivers/net/usb/asix.c      2008-11-04
>  19:51:06.000000000 +0200
>  +++ linux-next/drivers/net/usb/asix.c   2008-11-04 21:32:55.000000000 +0200
>  @@ -1102,12 +1102,14 @@
>         mode = AX88178_MEDIUM_DEFAULT;
> 
>         if (ecmd.speed == SPEED_1000)
>  -               mode |= AX_MEDIUM_GM | AX_MEDIUM_ENCK;
>  +               mode |= AX_MEDIUM_GM;
>         else if (ecmd.speed == SPEED_100)
>                 mode |= AX_MEDIUM_PS;
>         else
>                 mode &= ~(AX_MEDIUM_PS | AX_MEDIUM_GM);
> 
>  +       mode |= AX_MEDIUM_ENCK;
>  +
>         if (ecmd.duplex == DUPLEX_FULL)
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix asix-based gigabit cards connecting to 10 or 100Mbs networks
  2008-11-17 18:41 [PATCH] Fix asix-based gigabit cards connecting to 10 or 100Mbs networks Pantelis Koukousoulas
  2008-11-19 18:23 ` David Hollis
@ 2008-11-20  8:29 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2008-11-20  8:29 UTC (permalink / raw)
  To: pktoss; +Cc: netdev

From: "Pantelis Koukousoulas" <pktoss@gmail.com>
Date: Mon, 17 Nov 2008 20:41:57 +0200

> Add AX_MEDIUM_ENCK also when speed = 10/100Mbps. This allows my belkin
>  f5d5055 to work with my 100Mbps switch and with an old 10Mbps ISA card.
>  Without this patch, the card is recognized and the interface is brought
>  up fine, but no packets actually flow through the interface.
> 
>  Signed-off-by: Pantelis Koukousoulas <pktoss@gmail.com>
>  Acked-by: David Hollis <dhollis@davehollis.com>

This patch has been severely corrupted by your email client.

Please use the tips in linux/Documentation/email-clients.txt to
fix this up and then make a full resubmission (including commit
log message and signoffs).

Thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-11-20  8:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-17 18:41 [PATCH] Fix asix-based gigabit cards connecting to 10 or 100Mbs networks Pantelis Koukousoulas
2008-11-19 18:23 ` David Hollis
2008-11-20  8:29 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox