public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix asix-based cards connecting to 10/100Mbs LAN.
@ 2008-11-20  9:47 Pantelis Koukousoulas
  2008-11-20  9:48 ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Pantelis Koukousoulas @ 2008-11-20  9:47 UTC (permalink / raw)
  To: netdev; +Cc: Pantelis Koukousoulas

Add AX_MEDIUM_ENCK also when speed = 10/100Mbps. This allows my belkin
 f5d5055 to work with my 100Mbps switch and with an old 10Mbps ISA card.
 Without this patch, the card is recognized and the interface is brought
 up fine, but no packets actually flow through the interface.

Signed-off-by: Pantelis Koukousoulas <pktoss@gmail.com>
Acked-by: David Hollis <dhollis@davehollis.com>
---
 drivers/net/usb/asix.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
index e12cdb4..de57490 100644
--- a/drivers/net/usb/asix.c
+++ b/drivers/net/usb/asix.c
@@ -1102,12 +1102,14 @@ static int ax88178_link_reset(struct usbnet *dev)
 	mode = AX88178_MEDIUM_DEFAULT;
 
 	if (ecmd.speed == SPEED_1000)
-		mode |= AX_MEDIUM_GM | AX_MEDIUM_ENCK;
+		mode |= AX_MEDIUM_GM;
 	else if (ecmd.speed == SPEED_100)
 		mode |= AX_MEDIUM_PS;
 	else
 		mode &= ~(AX_MEDIUM_PS | AX_MEDIUM_GM);
 
+	mode |= AX_MEDIUM_ENCK;
+
 	if (ecmd.duplex == DUPLEX_FULL)
 		mode |= AX_MEDIUM_FD;
 	else
-- 
1.5.6.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] Fix asix-based cards connecting to 10/100Mbs LAN.
  2008-11-20  9:47 [PATCH] Fix asix-based cards connecting to 10/100Mbs LAN Pantelis Koukousoulas
@ 2008-11-20  9:48 ` David Miller
       [not found]   ` <1295ed070811200203j4ee959dcjbdd40738e6c3622c@mail.gmail.com>
  0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2008-11-20  9:48 UTC (permalink / raw)
  To: pktoss; +Cc: netdev

From: Pantelis Koukousoulas <pktoss@gmail.com>
Date: Thu, 20 Nov 2008 11:47:43 +0200

> Add AX_MEDIUM_ENCK also when speed = 10/100Mbps. This allows my belkin
>  f5d5055 to work with my 100Mbps switch and with an old 10Mbps ISA card.
>  Without this patch, the card is recognized and the interface is brought
>  up fine, but no packets actually flow through the interface.
> 
> Signed-off-by: Pantelis Koukousoulas <pktoss@gmail.com>
> Acked-by: David Hollis <dhollis@davehollis.com>

Patch applied, thank you.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Fix asix-based cards connecting to 10/100Mbs LAN.
       [not found]     ` <20081120.034831.268224100.davem@davemloft.net>
@ 2008-11-20 16:42       ` Pantelis Koukousoulas
  2008-11-21  4:40         ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Pantelis Koukousoulas @ 2008-11-20 16:42 UTC (permalink / raw)
  To: netdev

> Patch applied, thank you.

Thanks for applying :)
Should I expect this for 2.6.28 or 2.6.29 ?

Pantelis

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Fix asix-based cards connecting to 10/100Mbs LAN.
  2008-11-20 16:42       ` Pantelis Koukousoulas
@ 2008-11-21  4:40         ` David Miller
  2008-11-21 14:41           ` David Hollis
  0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2008-11-21  4:40 UTC (permalink / raw)
  To: pktoss; +Cc: netdev

From: "Pantelis Koukousoulas" <pktoss@gmail.com>
Date: Thu, 20 Nov 2008 18:42:10 +0200

> > Patch applied, thank you.
> 
> Thanks for applying :)
> Should I expect this for 2.6.28 or 2.6.29 ?

It's in Linus's tree already.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Fix asix-based cards connecting to 10/100Mbs LAN.
  2008-11-21  4:40         ` David Miller
@ 2008-11-21 14:41           ` David Hollis
  0 siblings, 0 replies; 5+ messages in thread
From: David Hollis @ 2008-11-21 14:41 UTC (permalink / raw)
  To: pktoss; +Cc: netdev

On Thu, 2008-11-20 at 20:40 -0800, David Miller wrote:
> From: "Pantelis Koukousoulas" <pktoss@gmail.com>
> Date: Thu, 20 Nov 2008 18:42:10 +0200
> 
> > > Patch applied, thank you.
> > 
> > Thanks for applying :)
> > Should I expect this for 2.6.28 or 2.6.29 ?
> 
> It's in Linus's tree already.

Which means that it will be in 2.6.28 final.

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-11-21 14:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-20  9:47 [PATCH] Fix asix-based cards connecting to 10/100Mbs LAN Pantelis Koukousoulas
2008-11-20  9:48 ` David Miller
     [not found]   ` <1295ed070811200203j4ee959dcjbdd40738e6c3622c@mail.gmail.com>
     [not found]     ` <20081120.034831.268224100.davem@davemloft.net>
2008-11-20 16:42       ` Pantelis Koukousoulas
2008-11-21  4:40         ` David Miller
2008-11-21 14:41           ` David Hollis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox