* [PATCH -tip] socket.h: extern's make no sense in userspace
@ 2009-01-13 8:20 Jaswinder Singh Rajput
0 siblings, 0 replies; only message in thread
From: Jaswinder Singh Rajput @ 2009-01-13 8:20 UTC (permalink / raw)
To: Ingo Molnar, netdev, sam, harvey.harrison, gorcunov, LKML
Impact: fix 2 make headers_check warnings:
usr/include/linux/socket.h:27: leaks CONFIG_PROC to userspace where it is not valid
usr/include/linux/socket.h:29: extern's make no sense in userspace
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
include/linux/socket.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/linux/socket.h b/include/linux/socket.h
index 20fc4bb..f5771a2 100644
--- a/include/linux/socket.h
+++ b/include/linux/socket.h
@@ -24,11 +24,6 @@ struct __kernel_sockaddr_storage {
#include <linux/types.h> /* pid_t */
#include <linux/compiler.h> /* __user */
-#ifdef CONFIG_PROC_FS
-struct seq_file;
-extern void socket_seq_show(struct seq_file *seq);
-#endif
-
typedef unsigned short sa_family_t;
/*
@@ -303,6 +298,11 @@ struct ucred {
#define IPX_TYPE 1
#ifdef __KERNEL__
+#ifdef CONFIG_PROC_FS
+struct seq_file;
+extern void socket_seq_show(struct seq_file *seq);
+#endif
+
extern int memcpy_fromiovec(unsigned char *kdata, struct iovec *iov, int len);
extern int memcpy_fromiovecend(unsigned char *kdata, struct iovec *iov,
int offset, int len);
--
1.5.6.6
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-01-13 8:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-13 8:20 [PATCH -tip] socket.h: extern's make no sense in userspace Jaswinder Singh Rajput
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox